Closed
Bug 1385218
Opened 7 years ago
Closed 7 years ago
The position of the items which doesn't have an indicator is wrong.
Categories
(Firefox :: Settings UI, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | unaffected |
| firefox55 | --- | unaffected |
| firefox56 | --- | verified |
People
(Reporter: hyacoub, Assigned: rickychien)
References
(Blocks 1 open bug)
Details
(Whiteboard: [photon-preference])
Attachments
(2 files)
position.png
[Affected versions]:
Nightly 56.0a1
[Affected platforms]:
Platforms: Windows 10 x 64, Ubuntu 16.04 and Mac OS X 10.12, Windows 7 x 86
[Steps to reproduce]:
1. Launch Firefox and go to "about:preferences".
2. search for "cookies".
3. Form "Search results" page click on the drop down to choose another history option.
[Expected result]:
The position of the items which doesn't have an indicator should be aligned with the rest of the items.
[Actual result]:
The position of the items which doesn't have an indicator is wrong.
|
Reporter | |
Updated•7 years ago
|
Blocks: 1357285
status-firefox54:
--- → unaffected
status-firefox55:
--- → unaffected
status-firefox56:
--- → affected
Whiteboard: [photon-preference][triage]
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: qe-verify+
Priority: -- → P1
Target Milestone: --- → Firefox 56
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 2•7 years ago
|
||
Solution is to override the Windows specific style which was introduced at http://searchfox.org/mozilla-central/source/toolkit/themes/windows/global/menu.css#95-98.
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8891874 [details]
Bug 1385218 - Fix incorrect arrow indicator position on Windows
https://reviewboard.mozilla.org/r/162894/#review168366
Seems good, but I didn't have a Windows machine on hand to test this with when I reviewed. Thanks!
Attachment #8891874 -
Flags: review?(mconley) → review+
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92b4376175ce
Fix incorrect arrow indicator position on Windows r=mconley
|
||
Updated•7 years ago
|
QA Contact: hani.yacoub
Whiteboard: [photon-preference][triage] → [photon-preference]
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 6•7 years ago
|
||
Build ID: 20170801100311
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•