The import offer on the New Tab page is lacking some paddings on RTL builds

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Activity Streams: Newtab
VERIFIED FIXED
5 months ago
5 months ago

People

(Reporter: Itiel, Assigned: tomer)

Tracking

({rtl})

unspecified
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 months ago
Created attachment 8891300 [details]
RTL import offer

See attached RTL vs. LTR.

The RTL offer banner is missing some paddings:
1. next to the (i) icon,
2. between the "Import Now" and the "No Thanks" buttons, and
3. between the "Import Now" and the banner's border.
(Reporter)

Comment 1

5 months ago
Created attachment 8891301 [details]
LTR import offer
(Assignee)

Updated

5 months ago
Assignee: nobody → tomer.moz.bugs
(Assignee)

Comment 2

5 months ago
I have provided a patch on https://github.com/mozilla/activity-stream/pull/3008.

Comment 3

5 months ago
Fixed with https://github.com/mozilla/activity-stream/pull/3008 to be uplifted via bug 1385133.
Blocks: 1385133
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED

Updated

5 months ago
status-firefox56: --- → fixed
Target Milestone: --- → Firefox 56
(Reporter)

Updated

5 months ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.