1385386 - OS X build failure in gfx/vr/openvr/ code (error: unknown type name 'NSString') caused by sccache

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Build output

I recently ran mach bootstrap to get the stuff needed for stylo, and now my build fails in the openvr code. See attachment for build output. This is on El Capitan, OS X 10.11.6.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

:O this is an sccache bug. I found the command that was failing (in $OBJDIR/gfx/vr/openvr). Running it without sccache works. Ted, known issue?

/Users/kats/.cargo/bin/sccache /usr/bin/clang++ -std=gnu++11 -o pathtools_public.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DVR_API_PUBLIC -DPOSIX -DOSX -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/Users/kats/zspace/mozilla-wr/gfx/vr/openvr -I/Users/kats/zspace/mozilla-wr/obj-host-opt/gfx/vr/openvr -I/Users/kats/zspace/mozilla-wr/toolkit/components/jsoncpp/include -I/Users/kats/zspace/mozilla-wr/obj-host-opt/dist/include  -I/Users/kats/zspace/mozilla-wr/obj-host-opt/dist/include/nspr -I/Users/kats/zspace/mozilla-wr/obj-host-opt/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /Users/kats/zspace/mozilla-wr/obj-host-opt/mozilla-config.h -MD -MP -MF .deps/pathtools_public.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g -g -fno-omit-frame-pointer  -Werror -xobjective-c++ -Wno-error=parentheses -Wno-error=unused-variable  /Users/kats/zspace/mozilla-wr/gfx/vr/openvr/src/pathtools_public.cpp

Comment 2

[Kartikaya Gupta (email:[e-mail])]

(The exact same thing happens with vrpathregistry_public.cpp in the same folder)

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Ted says glandium has a patch to fix this

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking 55/56 affected since this may be something we can fix during 56 beta (for the sdk update)

Comment 5

[Al Billings [:abillings - ex-MoCo]]

What's the ETA on this? We have a separate security issue that needs this fix as a prerequisite.

Comment 6

[(not currently active) Ted Mielczarek]

I merged glandium's sccache PR just now. I'll get an updated sccache landed in-tree and land the SDK update. Sorry for the delay!

Comment 7

[(not currently active) Ted Mielczarek]

Attachment: bug 1385386 - update sccache to revision 210bc791513ed8362b17a492a1f35a621cca64ff.

This picks up a fix we need to update the OS X SDK we build with.

Review commit: https://reviewboard.mozilla.org/r/169262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169262/

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 8897954 [details]
bug 1385386 - update sccache to revision 210bc791513ed8362b17a492a1f35a621cca64ff.

https://reviewboard.mozilla.org/r/169262/#review174686

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da78dd4e29fa
update sccache to revision 210bc791513ed8362b17a492a1f35a621cca64ff. r=glandium

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/da78dd4e29fa

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this something we can uplift for beta 56?

Comment 12

[(not currently active) Ted Mielczarek]

The fix here was just to update to a newer version of sccache, so it should be fine to uplift that to beta. Is it needed to unblock some other work? It's not super useful in and of itself.

Comment 13

[Mike Hommey [:glandium]]

Automation doesn't use sccache on beta, so it wouldn't do anything for automation.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

There was a sec issue dependent on this but I'll have to go back and dig around to find it - I forgot to mark this as a blocker.

Comment 15

[(not currently active) Ted Mielczarek]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #14)
> There was a sec issue dependent on this but I'll have to go back and dig
> around to find it - I forgot to mark this as a blocker.

Ah yes, there were some bugs that wanted the SDK update, and this was blocking that on nightly. If we're not using sccache for beta builds then this won't actually need uplift.