OS X build failure in gfx/vr/openvr/ code (error: unknown type name 'NSString') caused by sccache

RESOLVED FIXED in Firefox 57

Status

()

Core
WebVR
RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: kats, Assigned: glandium)

Tracking

56 Branch
mozilla57
x86_64
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 wontfix, firefox56 wontfix, firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Created attachment 8891455 [details]
Build output

I recently ran mach bootstrap to get the stuff needed for stylo, and now my build fails in the openvr code. See attachment for build output. This is on El Capitan, OS X 10.11.6.
Depends on: 1385388
:O this is an sccache bug. I found the command that was failing (in $OBJDIR/gfx/vr/openvr). Running it without sccache works. Ted, known issue?

/Users/kats/.cargo/bin/sccache /usr/bin/clang++ -std=gnu++11 -o pathtools_public.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DVR_API_PUBLIC -DPOSIX -DOSX -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/Users/kats/zspace/mozilla-wr/gfx/vr/openvr -I/Users/kats/zspace/mozilla-wr/obj-host-opt/gfx/vr/openvr -I/Users/kats/zspace/mozilla-wr/toolkit/components/jsoncpp/include -I/Users/kats/zspace/mozilla-wr/obj-host-opt/dist/include  -I/Users/kats/zspace/mozilla-wr/obj-host-opt/dist/include/nspr -I/Users/kats/zspace/mozilla-wr/obj-host-opt/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /Users/kats/zspace/mozilla-wr/obj-host-opt/mozilla-config.h -MD -MP -MF .deps/pathtools_public.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g -g -fno-omit-frame-pointer  -Werror -xobjective-c++ -Wno-error=parentheses -Wno-error=unused-variable  /Users/kats/zspace/mozilla-wr/gfx/vr/openvr/src/pathtools_public.cpp
Flags: needinfo?(ted)
(The exact same thing happens with vrpathregistry_public.cpp in the same folder)
Summary: OS X build failure in gfx/vr/openvr/ code → OS X build failure in gfx/vr/openvr/ code (error: unknown type name 'NSString') caused by sccache
Ted says glandium has a patch to fix this
Flags: needinfo?(ted)
Assignee: nobody → mh+mozilla
Blocks: 1324892
Marking 55/56 affected since this may be something we can fix during 56 beta (for the sdk update)
status-firefox55: --- → affected
status-firefox56: --- → affected

Comment 5

11 months ago
What's the ETA on this? We have a separate security issue that needs this fix as a prerequisite.

Updated

11 months ago
Flags: needinfo?(mh+mozilla)
I merged glandium's sccache PR just now. I'll get an updated sccache landed in-tree and land the SDK update. Sorry for the delay!
Flags: needinfo?(mh+mozilla)
Comment hidden (mozreview-request)
(Assignee)

Comment 8

11 months ago
mozreview-review
Comment on attachment 8897954 [details]
bug 1385386 - update sccache to revision 210bc791513ed8362b17a492a1f35a621cca64ff.

https://reviewboard.mozilla.org/r/169262/#review174686
Attachment #8897954 - Flags: review+

Comment 9

11 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/da78dd4e29fa
update sccache to revision 210bc791513ed8362b17a492a1f35a621cca64ff. r=glandium

Updated

11 months ago
Attachment #8897954 - Flags: review?(gps)

Comment 10

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/da78dd4e29fa
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Is this something we can uplift for beta 56?
Flags: needinfo?(mh+mozilla)
The fix here was just to update to a newer version of sccache, so it should be fine to uplift that to beta. Is it needed to unblock some other work? It's not super useful in and of itself.
(Assignee)

Comment 13

11 months ago
Automation doesn't use sccache on beta, so it wouldn't do anything for automation.
Flags: needinfo?(mh+mozilla)
There was a sec issue dependent on this but I'll have to go back and dig around to find it - I forgot to mark this as a blocker.
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #14)
> There was a sec issue dependent on this but I'll have to go back and dig
> around to find it - I forgot to mark this as a blocker.

Ah yes, there were some bugs that wanted the SDK update, and this was blocking that on nightly. If we're not using sccache for beta builds then this won't actually need uplift.
status-firefox55: affected → wontfix
status-firefox56: affected → wontfix
(Assignee)

Updated

8 months ago
Duplicate of this bug: 1385513
You need to log in before you can comment on or make changes to this bug.