1385435 - L10N repack failing on nightly

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Tom Prince [:tomprince]]

In Bug 1380780, client.py started requiring python 2.7. This causes https://dxr.mozilla.org/build-central/source/buildbotcustom/process/factory.py#2952 to fail, since at least the bld-linux64 workers default to python 2.6.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/433d0530406d
Allow python2.6 to run client.py; rs=bustage-fix

Comment 2

[Merike Sell (:merike)]

I think subprocess.check_output does not exist in 2.6 so the except block deleted in https://hg.mozilla.org/comm-central/rev/0e10366a7f2b is needed again?

From logs:
Traceback (most recent call last):
  File "client.py", line 84, in <module>
    from subprocess import check_call, check_output
ImportError: cannot import name check_output
program finished with exit code 1

Comment 3

[Jorg K (CEST = GMT+2)]

Right, as per https://docs.python.org/2/library/subprocess.html check_call is in 2.5, but check_output is in 2.7.

Comment 4

[Jorg K (CEST = GMT+2)]

Reopened as per comment #2.

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1385435-check_output.patch

Sadly I have no idea about Python, so it's just a cut and paste job ;-)

Comment 6

[Tom Prince [:tomprince]]

Comment on attachment 8891822 [details] [diff] [review]
1385435-check_output.patch

Review of attachment 8891822 [details] [diff] [review]:
-----------------------------------------------------------------

If we need to have compatibility code for python2.6, I'd rather figure out how to get this to run with python2.7. I'll take a look in the morning.

Comment 7

[Tom Prince [:tomprince]]

Attachment: Bug 1385435 - Use python 2.7 to run client.py in comm-central L10N repacks;

Review commit: https://reviewboard.mozilla.org/r/163204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163204/

Comment 8

[Tom Prince [:tomprince]]

Comment on attachment 8892285 [details]
Bug 1385435 - Use python 2.7 to run client.py in comm-central L10N repacks;

https://reviewboard.mozilla.org/r/163202/#review168566

I did some entirely unreasonable hacks to verify that python2.7 is available in PATH on every platform [here](https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=05d69f0e9c652bc7661c45b5bbc0538dc131ad4d).
- Windows: https://treeherder.mozilla.org/logviewer.html#?job_id=119853997&repo=try-comm-central&lineNumber=26973
- Linux: https://treeherder.mozilla.org/logviewer.html#?job_id=119853980&repo=try-comm-central&lineNumber=27391
- MacOS: https://treeherder.mozilla.org/logviewer.html#?job_id=119854002&repo=try-comm-central&lineNumber=16470

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8892285 [details]
Bug 1385435 - Use python 2.7 to run client.py in comm-central L10N repacks;

https://reviewboard.mozilla.org/r/163202/#review168688

This kind of thing tends to be a bit whack-a-mole, but r+ all the same.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8892285 [details]
Bug 1385435 - Use python 2.7 to run client.py in comm-central L10N repacks;

https://reviewboard.mozilla.org/r/163204/#review168690

Comment 11

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/build/buildbotcustom/rev/c48ef0db803e9a41faa37b5ba832acfdd8e38e88
https://hg.mozilla.org/build/buildbotcustom/rev/7f94ffa0a1d83fdc6fde2fdc9b2e45f9904a3af4 (production-0.8)

Ready for the next Daily run starting in one minute ;-)