Closed Bug 1385435 Opened 2 years ago Closed 2 years ago

L10N repack failing on nightly

Categories

(Thunderbird :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tomprince, Unassigned)

References

Details

Attachments

(2 files)

In Bug 1380780, client.py started requiring python 2.7. This causes https://dxr.mozilla.org/build-central/source/buildbotcustom/process/factory.py#2952 to fail, since at least the bld-linux64 workers default to python 2.6.
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/comm-central/rev/433d0530406d
Allow python2.6 to run client.py; rs=bustage-fix
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
I think subprocess.check_output does not exist in 2.6 so the except block deleted in https://hg.mozilla.org/comm-central/rev/0e10366a7f2b is needed again?

From logs:
Traceback (most recent call last):
  File "client.py", line 84, in <module>
    from subprocess import check_call, check_output
ImportError: cannot import name check_output
program finished with exit code 1
Reopened as per comment #2.
Status: RESOLVED → REOPENED
Flags: needinfo?(mozilla)
Resolution: FIXED → ---
Sadly I have no idea about Python, so it's just a cut and paste job ;-)
Flags: needinfo?(mozilla)
Attachment #8891822 - Flags: review?(mozilla)
Comment on attachment 8891822 [details] [diff] [review]
1385435-check_output.patch

Review of attachment 8891822 [details] [diff] [review]:
-----------------------------------------------------------------

If we need to have compatibility code for python2.6, I'd rather figure out how to get this to run with python2.7. I'll take a look in the morning.
Attachment #8891822 - Flags: review?(mozilla) → review-
Comment on attachment 8892285 [details]
Bug 1385435 - Use python 2.7 to run client.py in comm-central L10N repacks;

https://reviewboard.mozilla.org/r/163202/#review168688

This kind of thing tends to be a bit whack-a-mole, but r+ all the same.
Comment on attachment 8892285 [details]
Bug 1385435 - Use python 2.7 to run client.py in comm-central L10N repacks;

https://reviewboard.mozilla.org/r/163204/#review168690
Attachment #8892285 - Flags: review?(nthomas) → review+
https://hg.mozilla.org/build/buildbotcustom/rev/c48ef0db803e9a41faa37b5ba832acfdd8e38e88
https://hg.mozilla.org/build/buildbotcustom/rev/7f94ffa0a1d83fdc6fde2fdc9b2e45f9904a3af4 (production-0.8)

Ready for the next Daily run starting in one minute ;-)
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.