Don't use QI to canonicalize nsISupports pointers in the purple buffer

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
When dealing with things in the purple buffer, we QI twice. Once to get the canonical nsISupports object, and once to get the CC participant. I think that with the way things work now, we can avoid the first one, because we're always passing in a canonical nsISupports pointer, using the Upcast mechanism. This is a low-risk way to avoid some of the overhead.
(Assignee)

Comment 1

2 years ago
I think we can avoid both QIs for NoteXPCOMRoot because of the way it is used, though that will be a smaller win.
(Assignee)

Updated

2 years ago
Blocks: 1385474
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8891664 [details]
Bug 1385459 - Don't use QI to canonicalize nsISupports pointers in the purple buffer.

https://reviewboard.mozilla.org/r/162738/#review168464
Attachment #8891664 - Flags: review?(bugs) → review+

Comment 4

2 years ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80647273e2f0
Don't use QI to canonicalize nsISupports pointers in the purple buffer. r=smaug

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/80647273e2f0
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.