138588 - Convert CGIs to call new templates

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Gervase Markham [:gerv]]

We need to convert all the templatised .cgi and .pl files to use the new
templates  in template/en/default. After we check in bug 138581, which adds this
to the search path, we can do them a few at a time.

The procedure is to change the CGI and then, if the template has retained the
same name and path across the move, delete (and cvs remove) the old templates it
referenced.

This bug may turn into a tracking bug if we need several bugs to accomplish this.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Here's the first version. It's missing two things:
- the fix to the buglist.cgi problem Myk raised - that the templates and the
CGI don't have analogous names any more
- process_bug.cgi. I seem to have <ahem> forgotten the relevant templates. I
will rectify this error soon; but we need to decide what the new names are
first.

Gerv

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.2

v.2 - remedies both the above problems. Ready for review.

Gerv

Comment 3

[Andreas Franke (gone)]

Comment on attachment 80310 [details] [diff] [review]
Patch v.2

I have installed the patch, and tried to break it. So far, without success ;-)
The only regression I found (choose-product displaying only the first products,
and all the others empty) seems to be present even without this change.

The patch would be a bit easier to read if there wasn't all the mechanical
DisplayError -> ThrowTemplateError conversions, which could have been in a
separate patch which could easily get a x2-review, but since it's all the same
places, maybe this makes sense.
The second reviewer probably should just check whether the filename changes are
correct according to attachment 79842 [details] or whatever got checked into cvs...

t(ested)=afranke. Marking first-review.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 80310 [details] [diff] [review]
Patch v.2

Looks good, works. r=myk

Comment 5

[Gervase Markham [:gerv]]

Sorted. :-) 

Gerv

Comment 6

[Dave Miller [:justdave]]

This checkin broke the Tinderbox tests, tree is burning now.  Template test is
what's failing, says the templates are missing.  I'm guessing the tests are
probably looking for template/default instead of template/en/default.  Yep, that
they are.  ok, t/Support/Templates.pm has been checked in with the new search
path.  Got 4 templates failing the tests now, but that's a new bug.

Comment 7

[Gervase Markham [:gerv]]

We need to find some way of sharing template setup code; it's currently in two
(or three - checksetup.pl?) places. 

I'll find and fix the problems with the other templates tonight, unless someone
gets there before me.

Gerv

Comment 8

[David D. Kilzer (ddk)]

Gerv, see Bug 139787 regarding Tinderbox bustage.