1385884 - Stylo: With ABP installed (and huge filter list) and Stylo enabled, page continuously uses 100% CPU and does not finish loading

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Mayank Bansal]

Attachment: aboutsupport.txt

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170730100307

Steps to reproduce:

1. Enable stylo
2. install ABP

Go to http://www.digitaljournal.com/tech-and-science/technology/a-step-closer-to-skynet-ai-invents-a-language-humans-can-t-read/article/498142


Actual results:

Site keeps on loading, CPU usage is 100%
If you switch to another tab and then switch to this one, you will see a spinner


Expected results:

Not so

Comment 1

[Brad Werth [:bradwerth]]

I'll attempt to reproduce.

Comment 2

[Mayank Bansal]

I am on Win10x64, with OOP-Webextensions enabled by default. That might be a factor in reproducing.

Also, you might try using the filter list from here: https://bugzilla.mozilla.org/attachment.cgi?id=8890882  if the default filter list in ABP does not reproduce.

Comment 3

[Mayank Bansal]

OK, I confirmed this. So basically with Stylo+ABP, Nightly has two behaviors for this bug:

1. If the filter list is default that comes preloaded with ABP, then browser shows same behaviour as bug 1384945

2. If filter list is huge, as https://bugzilla.mozilla.org/attachment.cgi?id=8890882 this, then the browser shows the behavior described in comment 0

ni? so that you can see my findings.

Comment 4

[Mayank Bansal]

Attachment: MyFilters.ini

My filter list. Using this in ABP will reproduce behavior of comment 0

Comment 5

[Darkspirit]

(In reply to Mayank Bansal from comment #0)
> 1. Enable stylo
> 2. install ABP

I'm assuming you have installed the stable or dev version (both legacy) from https://addons.mozilla.org/firefox/addon/adblock-plus/ ?

(I am just a Nightly user)

Today is the birth of Firefox 57 and it won't support Legacy extensions, so I would request the Stylo people to only focus on webextension (or system addon) performance.
https://downloads.adblockplus.org/devbuilds/adblockplusfirefox/
If you've tested the webextension: Do you see the same behavior there? (If you haven't, could you please? :D)

(If you are using ABP personally, I would like to suggest you uBlock Origin https://github.com/gorhill/uBlock/releases)

Comment 6

[Darkspirit]

I can't reproduce either this nor bug 1384945 with ABP's webext on Debian testing. CPU is the same, RAM not that higher. Everything is smooth. Maybe this is architecture- or OS-specific?

Comment 7

[Brad Werth [:bradwerth]]

(In reply to Mayank Bansal from comment #4)
> Created attachment 8892458 [details]
> MyFilters.ini
> 
> My filter list. Using this in ABP will reproduce behavior of comment 0

Thank you for this. I can't figure out how to import your .ini file. I attempted to Add filter subscription -> Add a different subscription... and then put the file:// URL to the .ini file, but that was rejected with "Filter list location is neither a valid URL nor a valid file name." How do I import it?

Comment 8

[Mayank Bansal]

I cant reproduce this bug anymore.  I dont know if things changed in Stylo or ABP.
Please close this bug (and its dependent bug) appropriately.

Comment 9

[Bobby Holley (:bholley)]

(In reply to Mayank Bansal from comment #8)
> I cant reproduce this bug anymore.  I dont know if things changed in Stylo
> or ABP.
> Please close this bug (and its dependent bug) appropriately.

Thanks!