Closed Bug 1385988 Opened 2 years ago Closed 2 years ago

Highlights item separators disappear from the top when scrolling down

Categories

(Firefox for Android :: General, defect, P1)

All
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
1.29
Tracking Status
fennec + ---
firefox55 --- unaffected
firefox56 --- disabled
firefox57 --- verified

People

(Reporter: mcomella, Assigned: sebastian)

References

Details

(Whiteboard: [mobileAS])

Attachments

(2 files)

Attached image Screenshot
STR:
- With enough highlights that you need to scroll...
- Scroll down to see more highlights

Expected: item separators remain
Actual: item separators disappear

I'm guessing our math is off when we remove the item decoration separators in the recyclerView for the Highlights title & friends.
Priority: P1 → --
No longer blocks: as-android-blockers
Priority: -- → P3
Duplicate of this bug: 1388373
tracking-fennec: ? → +
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Comment on attachment 8905985 [details]
Bug 1385988 - HighlightsDividerItemDecoration: Use adapter position and not current position in parent view.

https://reviewboard.mozilla.org/r/177742/#review182848
Attachment #8905985 - Flags: review?(michael.l.comella) → review+
Iteration: --- → 1.29
Priority: P3 → P1
Pushed by michael.l.comella@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ae513db6d626
HighlightsDividerItemDecoration: Use adapter position and not current position in parent view. r=mcomella
Duplicate of this bug: 1397885
https://hg.mozilla.org/mozilla-central/rev/ae513db6d626
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Verified this using the steps in Comment 0 on a Nexus 5 (Android 6.0.1).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.