1385988 - Highlights item separators disappear from the top when scrolling down

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot

STR:
- With enough highlights that you need to scroll...
- Scroll down to see more highlights

Expected: item separators remain
Actual: item separators disappear

I'm guessing our math is off when we remove the item decoration separators in the recyclerView for the Highlights title & friends.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1385988 - HighlightsDividerItemDecoration: Use adapter position and not current position in parent view.

Review commit: https://reviewboard.mozilla.org/r/177742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177742/

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8905985 [details]
Bug 1385988 - HighlightsDividerItemDecoration: Use adapter position and not current position in parent view.

https://reviewboard.mozilla.org/r/177742/#review182848

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae513db6d626
HighlightsDividerItemDecoration: Use adapter position and not current position in parent view. r=mcomella

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ae513db6d626

Comment 7

[Bogdan Surd, QA [:bsurd, NI]]

Verified this using the steps in Comment 0 on a Nexus 5 (Android 6.0.1).