1386545 - Edit comment to stop false-positiveing for sdk/ usages in debounce.js file

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P1)

Description

[Soledad Penades [:sole] [:spenades]]

The comment in the header of devtools/shared/debounce.js mentions a SDK path, which triggers a false positive for bug 1350645 which consists on removing usages of the SDK: http://searchfox.org/mozilla-central/source/devtools/shared/debounce.js#13

We should replace:

from "sdk/lang/functional/concurrent.js"

into

from the SDK's "lang/functional/concurrent.js"

so it's still crediting the source, but doesn't trigger the positive on the search we're using: https://bugzilla.mozilla.org/show_bug.cgi?id=1350645#c12

Comment 1

[Hossain Al Ikram [:ikram] (QA Contact)]

I am trying to fix this one :) Hence, assigning myself.

Comment 2

[Hossain Al Ikram [:ikram] (QA Contact)]

Attachment: edited-comment.patch

Submitting this as patch. Let me know, If i should modify something :)

Comment 3

[Soledad Penades [:sole] [:spenades]]

Comment on attachment 8894092 [details] [diff] [review]
edited-comment.patch

Thank you Hossain! That was fast :)

This looks good to me. I'll request it be merged.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89cfa36b6fda
Edit comment to stop false-positiveing for sdk/ usages in debounce.js file. r=sole

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/89cfa36b6fda

Comment 6

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/89cfa36b6fdac80427003414befe9264d6d98013
Bug 1386545 - Edit comment to stop false-positiveing for sdk/ usages in debounce.js file. r=sole