Closed Bug 1386594 Opened 3 years ago Closed 3 years ago

Remove XULBrowserWindow.init

Categories

(Firefox :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Keywords: perf)

Attachments

(1 file)

(In reply to Florian Quèze [:florian] [:flo] (away until August 7th) from bug 1361347 comment #1)
> Here is a startup profile on a slow netbook, where we spend 34ms in
> refreshIdentityBlock: https://perfht.ml/2s1iTbR
> 
> I wonder if the code triggering this at
> http://searchfox.org/mozilla-central/rev/
> 1a0d9545b9805f50a70de703a3c04fc0d22e3839/browser/base/content/browser.
> js#4383 is really needed? I wouldn't be surprised if we didn't have a page
> loaded yet at that point.

(In reply to Dão Gottwald [::dao] from bug 1361347 comment #2)
> I think it's pretty much impossible to have page loaded there other than
> about:blank maybe.
Comment on attachment 8892848 [details]
Bug 1386594 - Remove XULBrowserWindow.init.

https://reviewboard.mozilla.org/r/163864/#review169666

I can't come up with anything that would break because of this, so cautious r+.
Attachment #8892848 - Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c47b8ff38121
Remove XULBrowserWindow.init. r=johannh
Keywords: perf
https://hg.mozilla.org/mozilla-central/rev/c47b8ff38121
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.