1386594 - Remove XULBrowserWindow.init

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Dão Gottwald [:dao]]

(In reply to Florian Quèze [:florian] [:flo] (away until August 7th) from bug 1361347 comment #1)
> Here is a startup profile on a slow netbook, where we spend 34ms in
> refreshIdentityBlock: https://perfht.ml/2s1iTbR
> 
> I wonder if the code triggering this at
> http://searchfox.org/mozilla-central/rev/
> 1a0d9545b9805f50a70de703a3c04fc0d22e3839/browser/base/content/browser.
> js#4383 is really needed? I wouldn't be surprised if we didn't have a page
> loaded yet at that point.

(In reply to Dão Gottwald [::dao] from bug 1361347 comment #2)
> I think it's pretty much impossible to have page loaded there other than
> about:blank maybe.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1386594 - Remove XULBrowserWindow.init.

Review commit: https://reviewboard.mozilla.org/r/163864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163864/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8892848 [details]
Bug 1386594 - Remove XULBrowserWindow.init.

https://reviewboard.mozilla.org/r/163864/#review169666

I can't come up with anything that would break because of this, so cautious r+.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c47b8ff38121
Remove XULBrowserWindow.init. r=johannh

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c47b8ff38121

Comment 5

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/c47b8ff381219ab9b1c63386f13f9f010a571e1f
Bug 1386594 - Remove XULBrowserWindow.init. r=johannh