Closed Bug 1386620 Opened 3 years ago Closed 3 years ago

Move devtools-startup from devtools/client to devtools/shim

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(3 files)

devtools-startup should be moved outside of devtools/client in prevision of devtools moving to an addon.

There is currently a patch attached to Bug 1369801 doing that, but it can land early.

See https://reviewboard.mozilla.org/r/156016/diff/6#index_header
Comment on attachment 8892901 [details]
Bug 1386620 - dt-addon: move devtools-startup to devtools shim folder;

https://reviewboard.mozilla.org/r/163926/#review169238

::: devtools/shim/moz.build:12
(Diff revision 1)
>  JAR_MANIFESTS += ['jar.mn']
>  
> +EXTRA_COMPONENTS += [
> +    'devtools-startup.js',
> +    'devtools-startup.manifest',
> +]

I think you want to put that next to aboutdebugging files, only when MOZ_DEVTOOLS != server
Attachment #8892901 - Flags: review?(poirot.alex) → review+
Comment on attachment 8892902 [details]
Bug 1386620 - dt-addon-prefs: move jsonview enabled pref outside of devtools addon;

https://reviewboard.mozilla.org/r/163928/#review169242

Looks good, but please wait for the tree to be merged before trying to land all this.
Attachment #8892902 - Flags: review?(poirot.alex) → review+
Comment on attachment 8892901 [details]
Bug 1386620 - dt-addon: move devtools-startup to devtools shim folder;

https://reviewboard.mozilla.org/r/163926/#review169238

> I think you want to put that next to aboutdebugging files, only when MOZ_DEVTOOLS != server

Good catch! Glad we moved this to a separate bug or we would have missed it :)
Comment on attachment 8892903 [details]
Bug 1386620 - dt-addon-prefs: move devtools.theme preference to devtools-startup-prefs.js;

https://reviewboard.mozilla.org/r/163930/#review169416
Attachment #8892903 - Flags: review?(bgrinstead) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f20d709776d9
dt-addon: move devtools-startup to devtools shim folder;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/e4c9887480c9
dt-addon-prefs: move jsonview enabled pref outside of devtools addon;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/de6e31587d98
dt-addon-prefs: move devtools.theme preference to devtools-startup-prefs.js;r=bgrins
Blocks: 1386821
https://hg.mozilla.org/projects/date/rev/f20d709776d90fac91dd346d00935e69e0c4a755
Bug 1386620 - dt-addon: move devtools-startup to devtools shim folder;r=ochameau

https://hg.mozilla.org/projects/date/rev/e4c9887480c94272de57a3625bc738bcc865623d
Bug 1386620 - dt-addon-prefs: move jsonview enabled pref outside of devtools addon;r=ochameau

https://hg.mozilla.org/projects/date/rev/de6e31587d982821851b2696c6c8e25d3ab733a7
Bug 1386620 - dt-addon-prefs: move devtools.theme preference to devtools-startup-prefs.js;r=bgrins
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.