1386620 - Move devtools-startup from devtools/client to devtools/shim

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

devtools-startup should be moved outside of devtools/client in prevision of devtools moving to an addon.

There is currently a patch attached to Bug 1369801 doing that, but it can land early.

See https://reviewboard.mozilla.org/r/156016/diff/6#index_header

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1386620 - dt-addon: move devtools-startup to devtools shim folder;

Review commit: https://reviewboard.mozilla.org/r/163926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163926/

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1386620 - dt-addon-prefs: move jsonview enabled pref outside of devtools addon;

DevTools preferences are loaded dynamically by calling DevtoolsPreferences.loadPrefs().
We can not preload them when the addon starts, otherwise this will slow down the startup
of Firefox.

But jsonview's converter-observer needs to check preferences to check if jsonview is
enabled very early. Moving devtools.jsonview.enabled to a separate preferences file
that is still processed by firefox fixes the issue.

The downside is that this pref will keep following m-c's release cycle and not the addon's.
But it is so generic it should not be a big issue.

Review commit: https://reviewboard.mozilla.org/r/163928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163928/

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1386620 - dt-addon-prefs: move devtools.theme preference to devtools-startup-prefs.js;

Review commit: https://reviewboard.mozilla.org/r/163930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163930/

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8892901 [details]
Bug 1386620 - dt-addon: move devtools-startup to devtools shim folder;

https://reviewboard.mozilla.org/r/163926/#review169238

::: devtools/shim/moz.build:12
(Diff revision 1)
>  JAR_MANIFESTS += ['jar.mn']
>  
> +EXTRA_COMPONENTS += [
> +    'devtools-startup.js',
> +    'devtools-startup.manifest',
> +]

I think you want to put that next to aboutdebugging files, only when MOZ_DEVTOOLS != server

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 8892902 [details]
Bug 1386620 - dt-addon-prefs: move jsonview enabled pref outside of devtools addon;

https://reviewboard.mozilla.org/r/163928/#review169242

Looks good, but please wait for the tree to be merged before trying to land all this.

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 8892901 [details]
Bug 1386620 - dt-addon: move devtools-startup to devtools shim folder;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163926/diff/1-2/

Comment 7

[Julian Descottes [:jdescottes]]

Comment on attachment 8892902 [details]
Bug 1386620 - dt-addon-prefs: move jsonview enabled pref outside of devtools addon;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163928/diff/1-2/

Comment 8

[Julian Descottes [:jdescottes]]

Comment on attachment 8892903 [details]
Bug 1386620 - dt-addon-prefs: move devtools.theme preference to devtools-startup-prefs.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163930/diff/1-2/

Comment 9

[Julian Descottes [:jdescottes]]

Comment on attachment 8892901 [details]
Bug 1386620 - dt-addon: move devtools-startup to devtools shim folder;

https://reviewboard.mozilla.org/r/163926/#review169238

> I think you want to put that next to aboutdebugging files, only when MOZ_DEVTOOLS != server

Good catch! Glad we moved this to a separate bug or we would have missed it :)

Comment 10

[Brian Grinstead [:bgrins]]

Comment on attachment 8892903 [details]
Bug 1386620 - dt-addon-prefs: move devtools.theme preference to devtools-startup-prefs.js;

https://reviewboard.mozilla.org/r/163930/#review169416

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f20d709776d9
dt-addon: move devtools-startup to devtools shim folder;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/e4c9887480c9
dt-addon-prefs: move jsonview enabled pref outside of devtools addon;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/de6e31587d98
dt-addon-prefs: move devtools.theme preference to devtools-startup-prefs.js;r=bgrins

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f20d709776d9
https://hg.mozilla.org/mozilla-central/rev/e4c9887480c9
https://hg.mozilla.org/mozilla-central/rev/de6e31587d98

Comment 13

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/f20d709776d90fac91dd346d00935e69e0c4a755
Bug 1386620 - dt-addon: move devtools-startup to devtools shim folder;r=ochameau

https://hg.mozilla.org/projects/date/rev/e4c9887480c94272de57a3625bc738bcc865623d
Bug 1386620 - dt-addon-prefs: move jsonview enabled pref outside of devtools addon;r=ochameau

https://hg.mozilla.org/projects/date/rev/de6e31587d982821851b2696c6c8e25d3ab733a7
Bug 1386620 - dt-addon-prefs: move devtools.theme preference to devtools-startup-prefs.js;r=bgrins