Closed
Bug 1386644
Opened 8 years ago
Closed 8 years ago
Fix and enable the mochitest for bug 1053321 on Android
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: mayhemer, Assigned: mayhemer)
References
Details
Attachments
(1 file)
|
5.22 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
Before we have cycles to fix bug 1386194 it would be good to land the test at https://bugzilla.mozilla.org/attachment.cgi?id=8892597&action=edit disabled on android. See https://bugzilla.mozilla.org/show_bug.cgi?id=1053321#c23 and c25 for details.
Comment 1•8 years ago
|
||
Note that we don't run wpt on Android yet anyway, so mochitest coverage is beneficial in that respect too.
Summary: Land mochitest for bug 1053321 → Fix and enable the mochitest for bug 1053321 on Android
Updated•8 years ago
|
Priority: -- → P2
| Assignee | ||
Comment 2•8 years ago
|
||
I believe this has been fixed with Bug 1392382 and can now be enabled.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4943c9c6243b6f5875eb65f47a0b71dc2f2235e5
Flags: needinfo?(honzab.moz)
| Assignee | ||
Comment 3•8 years ago
|
||
Still failing, trying more:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=315c1f1fc0a265089ef9fb82c34a079b78140b17&filter-searchStr=tc-M
Flags: needinfo?(honzab.moz)
| Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(honzab.moz)
| Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Flags: needinfo?(honzab.moz)
| Assignee | ||
Comment 4•8 years ago
|
||
The problem here is that from some reason we do the "unblock" requests two times on Android, always. No idea why, but the sjs code has to count with that.
| Assignee | ||
Comment 5•8 years ago
|
||
- there is no guarantee that an async scripts will run before onload in this case, fixed with explicit wait for both scripts to execute ; this was the root cause
- the sjs script is protected against duplicate requests for unblocking ; was another problem, but not root cause of the perma-failure
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac23623d6a5a0ff0e0c02d71db60e27804d9f337
Attachment #8941847 -
Flags: review?(bkelly)
Updated•8 years ago
|
Attachment #8941847 -
Flags: review?(bkelly) → review+
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fba47d2119b
Enable test for bug 1053321 on Android, r=bkelly
Keywords: checkin-needed
Comment 8•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•