1386658 - Update follow-on search add-on to 0.9.2 - additional domains and logging fix

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Mark Banner (:standard8)]

We want to push the latest version of the follow-on search add-on to nightly.

This includes:

- Correct logging of unexpected version names
- Add additional Yahoo domains

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1386658 - Update follow-on search add-on to 0.9.2 - additional domains and logging fix.

Review commit: https://reviewboard.mozilla.org/r/163948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163948/

Comment 2

[Mark Banner (:standard8)]

Link to release from github repo:

https://github.com/mozilla/followonsearch/releases/tag/v0.9.2

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8892928 [details]
Bug 1386658 - Update follow-on search add-on to 0.9.2 - additional domains and logging fix.

https://reviewboard.mozilla.org/r/163948/#review169260

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e15fc2ecf8cc
Update follow-on search add-on to 0.9.2 - additional domains and logging fix. r=past

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e15fc2ecf8cc

Comment 6

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/e15fc2ecf8cce9c5640347dc814845fd3f6f7a06
Bug 1386658 - Update follow-on search add-on to 0.9.2 - additional domains and logging fix. r=past

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8892928 [details]
Bug 1386658 - Update follow-on search add-on to 0.9.2 - additional domains and logging fix.

Approval Request Comment
[Feature/Bug causing the regression]: Improved follow-on search metrics for Yahoo
[User impact if declined]: N/A this is additionally telemetry data
[Is this code covered by automated tests?]: Currently manual.
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: This is needed for the uplift of bug 1393883 to maintain matching add-on versions.
[Is the change risky?]: No
[Why is the change risky/not risky?]: Simple addition of a couple of domains to an array.
[String changes made/needed]: None

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8892928 [details]
Bug 1386658 - Update follow-on search add-on to 0.9.2 - additional domains and logging fix.

Fix collecting telemetry data for Yahoo. Beta56+.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e32763a19631

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 8892928 [details]
Bug 1386658 - Update follow-on search add-on to 0.9.2 - additional domains and logging fix.

Approval Request Comment

For most details, see comment 7.

Requesting uplift alongside bug 1393883 as this shipped as a system add-on update and should be included in the next 55 dot release if there is one.

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 8892928 [details]
Bug 1386658 - Update follow-on search add-on to 0.9.2 - additional domains and logging fix.

m-r is about to become 56, so we should be fine without this in 55