Closed
Bug 1386784
Opened 8 years ago
Closed 7 years ago
Use a high resolution pic for bookmarks in activity stream
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: BesTo, Assigned: cynthiapereira)
References
Details
(Keywords: good-first-bug)
Attachments
(2 files)
17.74 KB,
image/png
|
Details | |
45 bytes,
patch
|
umohm12
:
review+
|
Details | Diff | Splinter Review |
Use a high resolution pic for bookmarks in activity stream.
Please look at the attached screenshot.
Maybe that's the favicon of mozilla.org...
And maybe that's a bug in AS that it use the wrong favicon...
Updated•8 years ago
|
Assignee: nobody → dylan
The image provided is <meta property="og:image" content="https://bugzilla.mozilla.org/extensions/OpenGraph/web/moz-social-bw-rgb-32x32.png">
We can replace this with a better or larger image if needed.
What size image is Activity Streams expecting?
The tradeoff is that this image will be used by any service that "unfurls" URLs.
Flags: needinfo?(Tobias.Besemer)
Keywords: good-first-bug
Reporter | ||
Comment 2•7 years ago
|
||
Sorry, I don't know the expected size.
Flags: needinfo?(Tobias.Besemer)
Assignee | ||
Comment 3•7 years ago
|
||
I sent a PR replacing this with a larger image that will fit in most common services.
https://github.com/mozilla-bteam/bmo/pull/216
Comment 4•7 years ago
|
||
Attachment #8900274 -
Flags: review?(umohm12)
Updated•7 years ago
|
Assignee: dylan → cynthiacpereira
Attachment #8900274 -
Attachment is patch: true
Attachment #8900274 -
Attachment mime type: text/x-github-pull-request → text/plain
Attachment #8900274 -
Flags: feedback?
Attachment #8900274 -
Flags: feedback? → feedback+
Attachment #8900274 -
Flags: feedback+ → review+
Updated•7 years ago
|
Attachment #8900274 -
Flags: review?(umohm12)
You need to log in
before you can comment on or make changes to this bug.
Description
•