Open Bug 1386910 Opened 2 years ago Updated 8 months ago

Google translate doesn't work in Firefox (meta refresh in iframe is blocked without the option of unblocking it), when the option "Warn you when websites try to redirect or reload the page" is set

Categories

(Firefox :: Disability Access, defect, P5)

54 Branch
defect

Tracking

()

Tracking Status
firefox57 --- wontfix

People

(Reporter: nivtwig, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: webcompat:needs-diagnosis, Whiteboard: [platform-rel-Google][needsdiagnosis])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170628075643

Steps to reproduce:

1. Set to true in Options / Advanced, the option "Warn you when websites try to redirect or reload the page"

2. Open translate.google.com

3. Enter a website URL to translate in the text-to-translate text field, for example www.bbc.com or https://en.wikipedia.org/wiki/Jordan 
i.e. The bug happens in both http and https pages .

4. Click on the search button to translate




Actual results:

The webpage doesn't translate. 

When translating a http webpage like www.bbc.com, google translate shows a yellow pop-up message :"This page was not retrieved from its original location over a secure connection.Dismiss". 
There is also a "Translating..." message. but no page translation is shown.

When translating a https webpage like https://en.wikipedia.org/wiki/Jordan , the yellow pop up message doesn't appear, only the "Translating..." message, but the page is still not translated .

In both cases, there is no indication that google translate tries to redirect or reload the page, so that the user can allow it to do so, as was expected if the option "Warn you when websites try to redirect or reload the page" is set. Google probably tries to reload the page since this works ok when the option is not set, and automatic reloading is allowed for the website.



Expected results:

*) The page should be translated, since it works ok in the Google Chrome browser, and it works ok when the option "Warn you when websites try to redirect or reload the page" is not set (i.e. automatic reload is allowed with no warning) .

*) Probably a warning should be displayed to the user, asking whether to allow reloading/ redirecting the page, as usually happens on websites that try to reload when the option is set.

Since it works ok when automatic redirection and reload is allowed, I guess that google translate tries to reload or redirect the page, but Firefox doesn't allow it because the option is set, but doesn't show any warning to the user, as it should and usually does, allowing the user to approve reload/redirect for the page.

The bug is both in Firefox 54.0.1 (release) and latest Nightly .
In Nightly, I didn't find this option in the options panel after the options panel changes  (I used the new search in options feature but still didn't find it).
Component: Untriaged → Document Navigation
Product: Firefox → Core
I can reproduce this on release 54 and beta 55 following STR. But I cannot reproduce this on latest nightly (currently 57) either on Mac or Win10.
(In reply to Hsin-Yi Tsai (55 Regression Engineering support) [:hsinyi] from comment #1)
> I can reproduce this on release 54 and beta 55 following STR. But I cannot
> reproduce this on latest nightly (currently 57) either on Mac or Win10.

Were you able to find the option "Warn you when websites try to redirect or reload the page", or a similar option in the Nightly options panel ? As I wrote, I didn't find this option.

Therefore maybe in my testing it was set (internally, without a UI option for changing it) in Nightly , and maybe in your testing it was not set internally in Nightly, and therefore you couldn't reproduce it . 

If you used the same profile for Nightly and release, maybe unsetting this option for the testing in release changed the internal option in Nightly, and therefore you couldn't reproduce the problem in Nightly (since when the option is unset, there is no problem)

*) If you reproduced it on release 54 and beta 55, can you or someone else please confirm the bug and change the status to NEW ? 
Or it must be reproduced in Nightly for the status change to NEW ?
(In reply to Hsin-Yi Tsai (55 Regression Engineering support) [:hsinyi] from comment #1)
> I can reproduce this on release 54 and beta 55 following STR. But I cannot
> reproduce this on latest nightly (currently 57) either on Mac or Win10.

In addition to comment 2,
According to https://bugzilla.mozilla.org/show_bug.cgi?id=941279#c5, this option was removed from Nightly's options UI as I suspected.
I checked what is the default for this option in Nightly.
The default for the internal about:config preference behind this UI option ("accessibility.blockautorefresh") is false.
Therefore in your Nightly testing you had this preference with the default ( unset), and in this case everything is ok.

To reproduce the bug in Nightly you probably need to change this option in about:config to true.
Flags: needinfo?(htsai)
(In reply to nivtwig from comment #2)
> (In reply to Hsin-Yi Tsai (55 Regression Engineering support) [:hsinyi] from
> comment #1)
> > I can reproduce this on release 54 and beta 55 following STR. But I cannot
> > reproduce this on latest nightly (currently 57) either on Mac or Win10.
> 
> Were you able to find the option "Warn you when websites try to redirect or
> reload the page", or a similar option in the Nightly options panel ? As I
> wrote, I didn't find this option.


As you, I didn't find the option on nightly 57.

> 
> Therefore maybe in my testing it was set (internally, without a UI option
> for changing it) in Nightly , and maybe in your testing it was not set
> internally in Nightly, and therefore you couldn't reproduce it . 
> 
> If you used the same profile for Nightly and release, maybe unsetting this
> option for the testing in release changed the internal option in Nightly,
> and therefore you couldn't reproduce the problem in Nightly (since when the
> option is unset, there is no problem)
> 
> *) If you reproduced it on release 54 and beta 55, can you or someone else
> please confirm the bug and change the status to NEW ? 
> Or it must be reproduced in Nightly for the status change to NEW ?

As it's too late to fix this issue on release 54 and beta 55 (which is going to be shipped in a few days), it makes more sense in this case to change the status based on the the behaviour on nightly57. 

With "accessibility.blockautorefresh" set as true, I encounter the issue as well.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(htsai)
As this issue appears when accessibility.blockautorefresh is set, Firefox:Disability Access seems a better fit.
Component: Document Navigation → Disability Access
Product: Core → Firefox
Given that we've removed this option from the UI, untracking for 57.

Mike, any idea what's going wrong here with your web compat experience? :-)
Flags: needinfo?(miket)
Priority: -- → P5
Let's move to TE::Desktop for diagnosis -- thanks!
Component: Disability Access → Desktop
Flags: needinfo?(miket)
Product: Firefox → Tech Evangelism
Whiteboard: [platform-rel-Google][needsdiagnosis]
Version: 54 Branch → Firefox 54
Attached image translate iframe
Here's a URL to test: https://translate.google.com/translate?hl=en&sl=en&tl=pt&u=https%3A%2F%2Fen.wikipedia.org%2Fwiki%2FJordan

So yeah, it looks like in their iframe below the translate controls UI, they include a meta refresh to load in the translated page:

<meta http-equiv="refresh" content="0;URL=https://translate.googleusercontent.com/translate_c?depth=1&amp;hl=en&amp;rurl=translate.google.com&amp;sl=en&amp;sp=nmt4&amp;tl=pt-BR&amp;u=https://en.wikipedia.org/wiki/Jordan&amp;usg=ALkJrhg-uSh5fMjt51nK3UPcDMxaGbHTMQ">

I'm not sure exactly what the outcome would be to this bug... feels kinda "expected behavior" if you flip this pref (though I admit it's confusing if you don't know why the page isn't working as expected). 

Maybe we could dump something to the devtools console as a hint that navigation/refresh was blocked?
Hi nivtwig,

(In reply to nivtwig from comment #0)
> Expected results:
> 
> *) The page should be translated, since it works ok in the Google Chrome
> browser, and it works ok when the option "Warn you when websites try to
> redirect or reload the page" is not set (i.e. automatic reload is allowed
> with no warning) .

Does it work in Chrome if a similar pref/setting is enabled? (I'm not sure that even exists...)

> *) Probably a warning should be displayed to the user, asking whether to
> allow reloading/ redirecting the page, as usually happens on websites that
> try to reload when the option is set.

Does Firefox display a warning to the user when a refresh is blocked?

(Forgive me, I didn't know this pref existed until today)
Flags: needinfo?(nivtwig)
(In reply to Mike Taylor [:miketaylr] from comment #9)
> > *) Probably a warning should be displayed to the user, asking whether to
> > allow reloading/ redirecting the page, as usually happens on websites that
> > try to reload when the option is set.
> 
> Does Firefox display a warning to the user when a refresh is blocked?
> 
> (Forgive me, I didn't know this pref existed until today)

Yep. So if there is a redirect (which I didn't realize...) and we're blocking it, we should be telling the user. I wonder why we don't... Maybe the message is broken for refreshes in iframes. :-(

Stealing the bug back. ;-)
Component: Desktop → Disability Access
Product: Tech Evangelism → Firefox
Summary: Google translate doesn't work in Firefox, when the option "Warn you when websites try to redirect or reload the page" is set. → Google translate doesn't work in Firefox (meta refresh in iframe is blocked without the option of unblocking it), when the option "Warn you when websites try to redirect or reload the page" is set
Version: Firefox 54 → 54 Branch
I don't think Chrome has a similar option, but if all that's going on here is that we're blocking the refresh without providing UI, it's just our bug, full stop. Thanks for your help Mike!
Flags: needinfo?(nivtwig)

See bug 1547409. Moving webcompat whiteboard tags to keywords.

You need to log in before you can comment on or make changes to this bug.