1386922 - [Form Autofill] Add "Learn more" links to SUMO pages in preferences

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[Scott Wu [:scottwu]]

Add links to SUMO pages that tell users more about the form autofill features.

UX spec: https://mozilla.invisionapp.com/share/AP8TFZ22G#/screens/228643733

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1386922 - Add learn more link to autofill address,

Review commit: https://reviewboard.mozilla.org/r/177638/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177638/

Comment 2

[Scott Wu [:scottwu]]

Attachment: Bug 1386922 - Add learn more link to autofill credit card,

Review commit: https://reviewboard.mozilla.org/r/177640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177640/

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8905829 [details]
Bug 1386922 - Add learn more link to autofill address,

https://reviewboard.mozilla.org/r/177638/#review182700

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8905830 [details]
Bug 1386922 - Add learn more link to autofill credit card,

https://reviewboard.mozilla.org/r/177640/#review182702

::: browser/extensions/formautofill/locales/en-US/formautofill.properties:10
(Diff revision 1)
>  preferenceGroupTitle = Form Autofill
>  enableAddressAutofill = Autofill addresses
>  addressAutofillLearnMore = Learn more
>  savedAddresses = Saved Addresses…
>  enableCreditCardAutofill = Autofill credit cards
> +creditCardAutofillLearnMore = Learn more

Looks like we can use the same id (and split it when we need afterward).

Comment 5

[Scott Wu [:scottwu]]

Comment on attachment 8905830 [details]
Bug 1386922 - Add learn more link to autofill credit card,

https://reviewboard.mozilla.org/r/177640/#review182702

> Looks like we can use the same id (and split it when we need afterward).

Cool I'll do that.

Comment 6

[Scott Wu [:scottwu]]

Comment on attachment 8905829 [details]
Bug 1386922 - Add learn more link to autofill address,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177638/diff/1-2/

Comment 7

[Scott Wu [:scottwu]]

Comment on attachment 8905830 [details]
Bug 1386922 - Add learn more link to autofill credit card,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177640/diff/1-2/

Comment 8

[Matthew N. [:MattN]]

Comment on attachment 8905829 [details]
Bug 1386922 - Add learn more link to autofill address,

https://reviewboard.mozilla.org/r/177638/#review183908

Thanks

Comment 9

[Matthew N. [:MattN]]

Comment on attachment 8905830 [details]
Bug 1386922 - Add learn more link to autofill credit card,

https://reviewboard.mozilla.org/r/177640/#review183938

::: browser/extensions/formautofill/locales/en-US/formautofill.properties:7
(Diff revision 2)
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  preferenceGroupTitle = Form Autofill
>  enableAddressAutofill = Autofill addresses
> -addressAutofillLearnMore = Learn more
> +learnMore = Learn more

Please make this change and the related reference changes in part 1 to avoid the intermediate changes.

Flod confirmed he's fine with sharing this string for now.

Comment 10

[Scott Wu [:scottwu]]

Comment on attachment 8905830 [details]
Bug 1386922 - Add learn more link to autofill credit card,

https://reviewboard.mozilla.org/r/177640/#review183938

> Please make this change and the related reference changes in part 1 to avoid the intermediate changes.
> 
> Flod confirmed he's fine with sharing this string for now.

Yes, thanks for spotting this. This should be on the first patch.

Comment 11

[Scott Wu [:scottwu]]

Comment on attachment 8905829 [details]
Bug 1386922 - Add learn more link to autofill address,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177638/diff/2-3/

Comment 12

[Scott Wu [:scottwu]]

Comment on attachment 8905830 [details]
Bug 1386922 - Add learn more link to autofill credit card,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177640/diff/2-3/

Comment 13

[Scott Wu [:scottwu]]

Checking this in. Thanks Matt and Luke.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/834aca219fbb
Add learn more link to autofill address, r=lchang,MattN
https://hg.mozilla.org/integration/autoland/rev/70d1f53f21f2
Add learn more link to autofill credit card, r=lchang,MattN

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/834aca219fbb
https://hg.mozilla.org/mozilla-central/rev/70d1f53f21f2

Comment 16

[Matthew N. [:MattN]]

Comment on attachment 8905829 [details]
Bug 1386922 - Add learn more link to autofill address,

Approval Request Comment
[Feature/Bug causing the regression]: Form autofill Learn More links to help users. We had to wait for the SUMO team to give us a URL.
[User impact if declined]: No additional information for users about what autofill is
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no, I manually verified yesterday on a local build
[List of other uplifts needed for the feature/fix]: None for this fix
[Is the change risky?]: No
[Why is the change risky/not risky?]: just adding learn more labels
[String changes made/needed]: Yes, but in files not part of the usual l10n process so it doesn't affect localizers at this time

Comment 17

[Matthew N. [:MattN]]

Comment on attachment 8905830 [details]
Bug 1386922 - Add learn more link to autofill credit card,

Approval Request Comment: See comment 16

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8905829 [details]
Bug 1386922 - Add learn more link to autofill address,

New link to SUMO for new feature. Let's uplift this for beta 12.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

This needs rebased patches for Beta uplift.

Comment 20

[Matthew N. [:MattN]]

Comment on attachment 8905830 [details]
Bug 1386922 - Add learn more link to autofill credit card,

Credit card support is not for 57 so I shouldn't have flagged this one.

Comment 21

[Matthew N. [:MattN]]

Attachment: Beta patch (address only)

Comment 22

[Matthew N. [:MattN]]

>  Attachment #8905829 [details] - Flags: approval-mozilla-beta+ → approval-mozilla-beta-

Was this from confusion due to comment 20? The address patch does still need uplift, just not the credit card one.

Comment 23

[Matthew N. [:MattN]]

Beta try push:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=61308c19743974fd98dc492cc8095a6c594f26cf

Comment 24

[Liz Henry (:lizzard) (relman/hg->git project)]

I see, yes, I misunderstood comment 20 to mean that we didn't need this uplifted. Ryan is working on it now.

Comment 25

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8907866 [details] [diff] [review]
Beta patch (address only)

3rd time's the charm.

Comment 26

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/faf98f63da30