Closed
Bug 1386922
Opened 7 years ago
Closed 7 years ago
[Form Autofill] Add "Learn more" links to SUMO pages in preferences
Categories
(Toolkit :: Form Manager, defect)
Toolkit
Form Manager
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
thunderbird_esr52 | --- | unaffected |
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | fixed |
firefox57 | --- | fixed |
People
(Reporter: scottwu, Assigned: scottwu)
References
(Blocks 1 open bug)
Details
(Whiteboard: [form autofill:MVP])
Attachments
(3 files)
59 bytes,
text/x-review-board-request
|
MattN
:
review+
lchang
:
review+
lizzard
:
approval-mozilla-beta-
|
Details |
59 bytes,
text/x-review-board-request
|
MattN
:
review+
lchang
:
review+
|
Details |
6.16 KB,
patch
|
MattN
:
review+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Add links to SUMO pages that tell users more about the form autofill features. UX spec: https://mozilla.invisionapp.com/share/AP8TFZ22G#/screens/228643733
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8905829 [details] Bug 1386922 - Add learn more link to autofill address, https://reviewboard.mozilla.org/r/177638/#review182700
Attachment #8905829 -
Flags: review?(lchang) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8905830 [details] Bug 1386922 - Add learn more link to autofill credit card, https://reviewboard.mozilla.org/r/177640/#review182702 ::: browser/extensions/formautofill/locales/en-US/formautofill.properties:10 (Diff revision 1) > preferenceGroupTitle = Form Autofill > enableAddressAutofill = Autofill addresses > addressAutofillLearnMore = Learn more > savedAddresses = Saved Addresses… > enableCreditCardAutofill = Autofill credit cards > +creditCardAutofillLearnMore = Learn more Looks like we can use the same id (and split it when we need afterward).
Attachment #8905830 -
Flags: review?(lchang) → review+
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8905830 [details] Bug 1386922 - Add learn more link to autofill credit card, https://reviewboard.mozilla.org/r/177640/#review182702 > Looks like we can use the same id (and split it when we need afterward). Cool I'll do that.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8905829 [details] Bug 1386922 - Add learn more link to autofill address, https://reviewboard.mozilla.org/r/177638/#review183908 Thanks
Attachment #8905829 -
Flags: review?(MattN+bmo) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8905830 [details] Bug 1386922 - Add learn more link to autofill credit card, https://reviewboard.mozilla.org/r/177640/#review183938 ::: browser/extensions/formautofill/locales/en-US/formautofill.properties:7 (Diff revision 2) > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > preferenceGroupTitle = Form Autofill > enableAddressAutofill = Autofill addresses > -addressAutofillLearnMore = Learn more > +learnMore = Learn more Please make this change and the related reference changes in part 1 to avoid the intermediate changes. Flod confirmed he's fine with sharing this string for now.
Attachment #8905830 -
Flags: review?(MattN+bmo) → review+
Assignee | ||
Comment 10•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8905830 [details] Bug 1386922 - Add learn more link to autofill credit card, https://reviewboard.mozilla.org/r/177640/#review183938 > Please make this change and the related reference changes in part 1 to avoid the intermediate changes. > > Flod confirmed he's fine with sharing this string for now. Yes, thanks for spotting this. This should be on the first patch.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 14•7 years ago
|
||
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/834aca219fbb Add learn more link to autofill address, r=lchang,MattN https://hg.mozilla.org/integration/autoland/rev/70d1f53f21f2 Add learn more link to autofill credit card, r=lchang,MattN
Keywords: checkin-needed
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/834aca219fbb https://hg.mozilla.org/mozilla-central/rev/70d1f53f21f2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 16•7 years ago
|
||
Comment on attachment 8905829 [details] Bug 1386922 - Add learn more link to autofill address, Approval Request Comment [Feature/Bug causing the regression]: Form autofill Learn More links to help users. We had to wait for the SUMO team to give us a URL. [User impact if declined]: No additional information for users about what autofill is [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: no, I manually verified yesterday on a local build [List of other uplifts needed for the feature/fix]: None for this fix [Is the change risky?]: No [Why is the change risky/not risky?]: just adding learn more labels [String changes made/needed]: Yes, but in files not part of the usual l10n process so it doesn't affect localizers at this time
Attachment #8905829 -
Flags: approval-mozilla-beta?
Comment 17•7 years ago
|
||
Comment on attachment 8905830 [details] Bug 1386922 - Add learn more link to autofill credit card, Approval Request Comment: See comment 16
Attachment #8905830 -
Flags: approval-mozilla-beta?
Updated•7 years ago
|
status-firefox55:
--- → unaffected
status-firefox56:
--- → affected
status-firefox-esr52:
--- → unaffected
Comment 18•7 years ago
|
||
Comment on attachment 8905829 [details] Bug 1386922 - Add learn more link to autofill address, New link to SUMO for new feature. Let's uplift this for beta 12.
Attachment #8905829 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 20•7 years ago
|
||
Comment on attachment 8905830 [details] Bug 1386922 - Add learn more link to autofill credit card, Credit card support is not for 57 so I shouldn't have flagged this one.
Attachment #8905830 -
Flags: approval-mozilla-beta?
Updated•7 years ago
|
Attachment #8905829 -
Flags: approval-mozilla-beta+ → approval-mozilla-beta-
Comment 21•7 years ago
|
||
Flags: needinfo?(scwwu)
Attachment #8907866 -
Flags: review+
Updated•7 years ago
|
Attachment #8907866 -
Attachment description: Beta patch → Beta patch (address only)
Comment 22•7 years ago
|
||
> Attachment #8905829 [details] - Flags: approval-mozilla-beta+ → approval-mozilla-beta- Was this from confusion due to comment 20? The address patch does still need uplift, just not the credit card one.
Flags: needinfo?(lhenry)
Comment 23•7 years ago
|
||
Beta try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=61308c19743974fd98dc492cc8095a6c594f26cf
Comment 24•7 years ago
|
||
I see, yes, I misunderstood comment 20 to mean that we didn't need this uplifted. Ryan is working on it now.
Flags: needinfo?(lhenry)
Comment 25•7 years ago
|
||
Comment on attachment 8907866 [details] [diff] [review] Beta patch (address only) 3rd time's the charm.
Attachment #8907866 -
Flags: approval-mozilla-beta+
Comment 26•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/faf98f63da30
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•