1386975 - (photon) Enable Photon by default

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Jing-wei Wu [:jwu]]

Photon is targeted on 57, it's time to enable it by default on Nightly.

Comment 1

[Jing-wei Wu [:jwu]]

Attachment: Bug 1386975 - Part 1: Use Photon resources to build Fennec.

Remove '--enable-photon' option and use Photon resources to build Fennec.

This patch prohibits changing skin(Australis/Photon) in mach build because we would drop Australis resources in near future.

Any modification in Nightly after this patch should only affect Photon.

Review commit: https://reviewboard.mozilla.org/r/164846/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164846/

Comment 2

[Jing-wei Wu [:jwu]]

Attachment: Bug 1386975 - Part 2: Fix Robocop/Mochitest-chrome errors when Photon is enabled.

Review commit: https://reviewboard.mozilla.org/r/164848/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164848/

Comment 3

[Jing-wei Wu [:jwu]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=235b497ac9fea0dabb63a7671cbb226d9db8a5cf

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8893727 [details]
Bug 1386975 - Part 1: Use Photon resources to build Fennec.

https://reviewboard.mozilla.org/r/164846/#review170248

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8893728 [details]
Bug 1386975 - Part 2: Fix Robocop/Mochitest-chrome errors when Photon is enabled.

https://reviewboard.mozilla.org/r/164848/#review170250

Comment 6

[Max Liu [:maliu]]

Comment on attachment 8893727 [details]
Bug 1386975 - Part 1: Use Photon resources to build Fennec.

https://reviewboard.mozilla.org/r/164846/#review170740

Comment 7

[Max Liu [:maliu]]

Comment on attachment 8893728 [details]
Bug 1386975 - Part 2: Fix Robocop/Mochitest-chrome errors when Photon is enabled.

https://reviewboard.mozilla.org/r/164848/#review170742

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88017de7130d
Part 1: Use Photon resources to build Fennec. r=maliu,sebastian
https://hg.mozilla.org/integration/autoland/rev/bd83328c7773
Part 2: Fix Robocop errors when Photon is enabled. r=maliu,sebastian

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing chrome tests on Android 4.2 x86 opt:

https://hg.mozilla.org/integration/autoland/rev/df30da8bc862d763d715b405cca23d398ee5312e
https://hg.mozilla.org/integration/autoland/rev/0701ae812e9f47a24c666dfe3aff046e480381c4

The screenshot shows a crash.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bd83328c7773af9ed1c22592532c3d8da9b2a1a5&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=121445805&repo=autoland

[task 2017-08-07T16:18:08.729418Z] 16:18:08     INFO -  pushing /home/worker/workspace/build/tests/mochitest/chrome to /mnt/sdcard/tests/chrome on device...
[task 2017-08-07T16:19:45.927950Z] 16:19:45     INFO -  runtests.py | Failed to copy /home/worker/workspace/build/tests/mochitest/hyphenation to profile
[task 2017-08-07T16:19:46.422746Z] 16:19:46     INFO -  pk12util: PKCS12 IMPORT SUCCESSFUL
[task 2017-08-07T16:19:46.936763Z] 16:19:46     INFO -  MochitestServer : launching [u'/home/worker/workspace/build/hostutils/host-utils-50.0a1.en-US.linux-x86_64/xpcshell', '-g', '/home/worker/workspace/build/hostutils/host-utils-50.0a1.en-US.linux-x86_64', '-v', '170', '-f', '/home/worker/workspace/build/hostutils/host-utils-50.0a1.en-US.linux-x86_64/components/httpd.js', '-e', "const _PROFILE_PATH = '/tmp/tmpI8XSgj.mozrunner'; const _SERVER_PORT = '8854'; const _SERVER_ADDR = '10.0.2.2'; const _TEST_PREFIX = undefined; const _DISPLAY_RESULTS = false;", '-f', '/home/worker/workspace/build/tests/mochitest/server.js']
[task 2017-08-07T16:19:46.937023Z] 16:19:46     INFO -  runtests.py | Server pid: 1061
[task 2017-08-07T16:19:46.942001Z] 16:19:46     INFO -  runtests.py | Websocket server pid: 1064
[task 2017-08-07T16:19:46.955178Z] 16:19:46     INFO -  runtests.py | SSL tunnel pid: 1067
[task 2017-08-07T16:19:52.423059Z] 16:19:52     INFO -  runtests.py | Running with e10s: False
[task 2017-08-07T16:19:52.423522Z] 16:19:52     INFO -  runtests.py | Running tests: start.
[task 2017-08-07T16:20:02.221668Z] 16:20:02     INFO -  INFO | automation.py | Application pid: 1911
[task 2017-08-07T16:26:04.075489Z] 16:26:04     INFO -  TEST-INFO | started process screentopng
[task 2017-08-07T16:26:04.408099Z] 16:26:04     INFO -  TEST-INFO | screentopng: exit 0
[task 2017-08-07T16:26:10.510125Z] 16:26:10  WARNING -  TEST-UNEXPECTED-FAIL | remoteautomation.py | application timed out after 330 seconds with no output

Comment 10

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8893727 [details]
Bug 1386975 - Part 1: Use Photon resources to build Fennec.

https://reviewboard.mozilla.org/r/164846/#review170832

lgtm.  I'll defer to others for the rest of this process though -- I'm on parental leave and shouldn't block anybody.

Comment 11

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8893728 [details]
Bug 1386975 - Part 2: Fix Robocop/Mochitest-chrome errors when Photon is enabled.

https://reviewboard.mozilla.org/r/164848/#review170834

Comment 12

[Jing-wei Wu [:jwu]]

Comment on attachment 8893727 [details]
Bug 1386975 - Part 1: Use Photon resources to build Fennec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164846/diff/1-2/

Comment 13

[Jing-wei Wu [:jwu]]

Comment on attachment 8893728 [details]
Bug 1386975 - Part 2: Fix Robocop/Mochitest-chrome errors when Photon is enabled.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164848/diff/1-2/

Comment 14

[Jing-wei Wu [:jwu]]

The previous patches didn't consider mochitest chrome test, here is the result with new patches:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fc9459d5782043100ef71c58b4d5431e27414e1

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64adea19eb04
Part 1: Use Photon resources to build Fennec. r=maliu,nalexander,sebastian
https://hg.mozilla.org/integration/autoland/rev/6df7dff00b94
Part 2: Fix Robocop/Mochitest-chrome errors when Photon is enabled. r=maliu,nalexander,sebastian

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/64adea19eb04
https://hg.mozilla.org/mozilla-central/rev/6df7dff00b94

Comment 17

[Oana Horvath [:ohorvath]]

Photon UI is now the default on Nightly 57. Verified as fixed.