1387003 - Add new container icons to Firefox

Status: RESOLVED FIXED

(Firefox :: Security, enhancement)

Description

[Jonathan Kingston [:jkt] he/him]

As part of the test pilot work we added new icons. We should also add them to central.

Comment 1

[Jonathan Kingston [:jkt] he/him]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e76760e19a04dbec76fd1ba6fe451b44225ada43

Comment 2

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1387003 - Adding container icons from test pilot experiment.

Review commit: https://reviewboard.mozilla.org/r/164450/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164450/

Comment 3

[Jonathan Kingston [:jkt] he/him]

To clarify :jaws, the tab highlight/icon colours changed as part of the test pilot also.

I don't think there is any risk in landing this, these icons are currently narrower than the briefcase which is already present. I checked this in central and looks correct, the reduction in the radio size was the slight cropping on the right hand side for the modal in about:preferences#containers.

Please note Bug 1386627 already exists for URL bar alignment of these icons since photon changes landed.

Comment 4

[Jonathan Kingston [:jkt] he/him]

Currently building a different build, I forgot to check in the icons sorry about that.

Comment 5

[Jonathan Kingston [:jkt] he/him]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f81a9349cd622d0886e9505b6548a0175ec6cbe

Comment 6

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 8893357 [details]
Bug 1387003 - Adding container icons from test pilot experiment.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164450/diff/1-2/

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8893357 [details]
Bug 1387003 - Adding container icons from test pilot experiment.

https://reviewboard.mozilla.org/r/164450/#review170000

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bfb12529f01
Adding container icons from test pilot experiment. r=jaws

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0bfb12529f01

Comment 10

[Francesco Lodolo [:flod]]

Why are we still adding strings to preferences-old at this point, since we're shipping the reorg to all locales with 56? Is there a bug tracking its complete removal from the tree?

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

The new preferences are shipping with 56 which hasn't been released yet. We'll need to wait until we release the new preferences and see that there are no issues that are found which cause us to push out a hotfix reverting back to the old preferences. Until then we should keep maintaining preferences-old. I expect we should be able to remove the old preferences about halfway through the 57 cycle but I would like to leave them in for now just to be cautious.

Bug 1349689 is on file to remove the old preferences.