Closed Bug 1387003 Opened 2 years ago Closed 2 years ago

Add new container icons to Firefox

Categories

(Firefox :: Security, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: jkt, Assigned: jkt)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As part of the test pilot work we added new icons. We should also add them to central.
To clarify :jaws, the tab highlight/icon colours changed as part of the test pilot also.

I don't think there is any risk in landing this, these icons are currently narrower than the briefcase which is already present. I checked this in central and looks correct, the reduction in the radio size was the slight cropping on the right hand side for the modal in about:preferences#containers.

Please note Bug 1386627 already exists for URL bar alignment of these icons since photon changes landed.
Flags: needinfo?(jaws)
Currently building a different build, I forgot to check in the icons sorry about that.
Comment on attachment 8893357 [details]
Bug 1387003 - Adding container icons from test pilot experiment.

https://reviewboard.mozilla.org/r/164450/#review170000
Attachment #8893357 - Flags: review?(jaws) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0bfb12529f01
Adding container icons from test pilot experiment. r=jaws
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0bfb12529f01
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Why are we still adding strings to preferences-old at this point, since we're shipping the reorg to all locales with 56? Is there a bug tracking its complete removal from the tree?
Flags: needinfo?(jaws)
The new preferences are shipping with 56 which hasn't been released yet. We'll need to wait until we release the new preferences and see that there are no issues that are found which cause us to push out a hotfix reverting back to the old preferences. Until then we should keep maintaining preferences-old. I expect we should be able to remove the old preferences about halfway through the 57 cycle but I would like to leave them in for now just to be cautious.

Bug 1349689 is on file to remove the old preferences.
Flags: needinfo?(jaws)
You need to log in before you can comment on or make changes to this bug.