Closed Bug 1387092 Opened 3 years ago Closed 3 years ago

Add support for proxyType "direct" (noproxy)

Categories

(Testing :: Marionette, enhancement, P1)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [spec][17/08])

Attachments

(2 files, 2 obsolete files)

The webdriver spec has been updated a while ago to get rid of the irritation between noProxy as proxyType and the actual setting for hosts, not using a proxy:

https://github.com/w3c/webdriver/commit/a90db4b119de8c77875647e30b611c1c49a4349b#diff-ce5a67d95770dc70b1b4250c7a9348f2L1905

As such Marionette needs to be updated to support `proxyType: direct` instead of `proxyType: noProxy`.
This change will also involve a change for webdriver-rust:
https://github.com/mozilla/webdriver-rust/blob/bdd5efda8cf6acb5be1207a77be86e16e1fb5128/src/capabilities.rs#L152

I talked to Andreas on IRC and we decided to just make the change, without leaving a fallback behind.
This bug needs https://github.com/mozilla/webdriver-rust/issues/106 to be fixed, and a new crate released.
A new release of webdriver-rust was created and will be merged with bug 1388365. So once that landed I can finish off this bug.
Depends on: 1388365
Attachment #8896199 - Attachment is obsolete: true
Attachment #8896200 - Attachment is obsolete: true
Attachment #8896201 - Flags: review?(ato)
Attachment #8896364 - Flags: review?(ato)
Comment on attachment 8896201 [details]
Bug 1387092 - Add support for proxyType "direct".

https://reviewboard.mozilla.org/r/167488/#review174064

::: testing/marionette/harness/marionette_harness/tests/unit/test_capabilities.py
(Diff revision 3)
> -    allowed = [None, "*"]
> -    disallowed = ["", 42, True, {}, []]
>  
>      def setUp(self):
>          MarionetteTestCase.setUp(self)
> -        self.browser_name = self.marionette.session_capabilities["browserName"]
> -        self.platform_name = self.marionette.session_capabilities["platformName"]

Thanks for removing this.
Attachment #8896201 - Flags: review?(ato) → review+
Comment on attachment 8896364 [details]
Bug 1387092 - Update geckodriver readme for proxyType 'direct'.

https://reviewboard.mozilla.org/r/167618/#review174066

Good thing you remembered to fix the README too.
Attachment #8896364 - Flags: review?(ato) → review+
Attachment #8896201 - Flags: review?(dburns)
Attachment #8896364 - Flags: review?(dburns)
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30805fec70ed
Add support for proxyType "direct". r=ato
https://hg.mozilla.org/integration/autoland/rev/32d34008eec5
Update geckodriver readme for proxyType 'direct'. r=ato
Backed out for failing testing/marionette/test_session.js | test_Proxy_init:

https://hg.mozilla.org/integration/autoland/rev/d5f40050d2df0075acc5312a14926e57657bbd1d
https://hg.mozilla.org/integration/autoland/rev/8c82dabc8e365797e23dd2670b3ca54600fe34c2

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=32d34008eec537b9b2234368c7e4214d5fca55ee&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=runnable&filter-resultStatus=usercancel
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=123290207&repo=autoland

09:43:31  WARNING -  TEST-UNEXPECTED-FAIL | testing/marionette/test_session.js | test_Proxy_init - [test_Proxy_init : 150] false == true
09:43:31     INFO -  /Users/cltbld/tasks/task_1502813895/build/tests/xpcshell/tests/testing/marionette/test_session.js:test_Proxy_init:150
09:43:31     INFO -  /Users/cltbld/tasks/task_1502813895/build/tests/xpcshell/head.js:_run_next_test:1503
09:43:31     INFO -  /Users/cltbld/tasks/task_1502813895/build/tests/xpcshell/head.js:run:701
09:43:31     INFO -  /Users/cltbld/tasks/task_1502813895/build/tests/xpcshell/head.js:_do_main:221
09:43:31     INFO -  /Users/cltbld/tasks/task_1502813895/build/tests/xpcshell/head.js:_execute_test:544
09:43:31     INFO -  -e:null:1
Flags: needinfo?(hskupin)
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/52c0c3d1c0b3
Add support for proxyType "direct". r=ato
https://hg.mozilla.org/integration/autoland/rev/a9a6206bf938
Update geckodriver readme for proxyType 'direct'. r=ato
https://hg.mozilla.org/mozilla-central/rev/52c0c3d1c0b3
https://hg.mozilla.org/mozilla-central/rev/a9a6206bf938
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Flags: needinfo?(hskupin)
Whiteboard: [spec][17/08]
You need to log in before you can comment on or make changes to this bug.