Closed
Bug 1387161
Opened 7 years ago
Closed 7 years ago
'Bookmark this page' icon shifts when user types in the urlbar
Categories
(Firefox :: Theme, defect, P1)
Firefox
Theme
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | fixed |
People
(Reporter: Abe_LV, Assigned: jaws)
References
Details
(Keywords: regression, Whiteboard: [reserve-photon-animation][fixed by bug 1392685])
Steps to reproduce: 1.Open latest nightly and go to any site or https://www.mozilla.org/en-US/ 2.Click the "bookmark this page" icon from the url-bar but do not click 'Done' 3.Type any letter (e.g. 'h') in the url-bar and check the position of the icon Actual Result The icon shifts to the right Expected Result "bookmark this page" icon should remain at the same position Screenshot is here: https://testing-1.tinytake.com/sf/MTg0MTc2NV81OTQ5ODU5 Regression range: Last good revision: 87824406b9feb420a3150720707b424d7cee5915 First bad revision: 8b19670d12fde57d3aee50a5a7d1c734d9b709d5 Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=87824406b9feb420a3150720707b424d7cee5915&tochange=8b19670d12fde57d3aee50a5a7d1c734d9b709d5
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(jaws)
Comment 1•7 years ago
|
||
[Tracking Requested - why for this release]: Nav bar layoyt glitch Regression window: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9d617ec5226cf6962dea3aa85e6595e961a9ed25&tochange=fe8012cc708af4ae9c3ad366decbbb32832a18f7 Regressed by: fe8012cc708a Jared Wein — Bug 1385407 - Add an extra selector for the urlbar-icon within the star-button-box now that the urlbar-icon for the bookmark star isn't a direct child of urlbar-icons. r=Gijs
Blocks: 1385407
status-firefox55:
--- → unaffected
status-firefox56:
--- → affected
status-firefox-esr52:
--- → unaffected
tracking-firefox56:
--- → ?
Keywords: regression
Updated•7 years ago
|
Whiteboard: [photon-animation] [triage]
Assignee | ||
Comment 2•7 years ago
|
||
I can only reproduce this when following the steps from comment #0. If I switch to a tab that already is bookmarked or open a new tab to a page that is bookmarked then I don't see this bug, so I'm putting this as P4. Off the top of my head I'm thinking it has to do with the presence of the "animate" attribute.
Flags: needinfo?(jaws)
Priority: -- → P4
Whiteboard: [photon-animation] [triage] → [reserve-photon-animation]
Updated•7 years ago
|
Flags: qe-verify+
QA Contact: jwilliams
Updated•7 years ago
|
Assignee | ||
Comment 3•7 years ago
|
||
This is fixed by bug 1392685.
Assignee: nobody → jaws
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [reserve-photon-animation] → [reserve-photon-animation][fixed by bug 1392685]
Assignee | ||
Comment 4•7 years ago
|
||
This doesn't affect Firefox 56 since this is related to the bookmark animation which is only shipping in Firefox 57.
Updated•7 years ago
|
Iteration: --- → 57.2 - Aug 29
Priority: P4 → P1
Updated•7 years ago
|
Target Milestone: --- → Firefox 57
Comment 5•7 years ago
|
||
I have reproduced this bug with Nightly 57.0a1 (2017-08-03) on Ubuntu 16.04, 64 bit! The fix is now verified on Latest Nightly 57.0a1 . Build ID 20170829100404 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170830]
Comment 6•7 years ago
|
||
I have successfully reproduced this bug with Nightly 57.0a1 (2017-08-03) on windows 10(32bit) this bug is verified fix with latest nightly 57.0a1 (2017-08-29) (32-bit) Build ID: 20170829100404 Mozilla/5.0 (Windows NT 10.0; rv:57.0) Gecko/20100101 Firefox/57.0 [bugday-20170830]
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•