1387184 - Remove nsIDOMHTMLEmbedElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Since it is no longer used (superceded by WebIDL), we can remove the members of nsIDOMHTMLEmbedElement, preparing it for complete removal when 57 moves to beta.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1387184 - Remove nsIDOMHTMLEmbedElement;

Removes nsIDOMHTMLEmbedElement and all references. HTML elements are
now handled by WebIDL. With the deprecation of extensions, XPCOM
interfaces to HTML elements are no longer needed.

Review commit: https://reviewboard.mozilla.org/r/166810/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166810/

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Since the pref to turn off extensions is supposed to land in nightly this week, I went ahead and removed the whole interface in this bug. Getting reviews now as it has passed try, but will wait to land until after pref is changed (need to find bug # for that).

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8895597 [details]
Bug 1387184 - Remove nsIDOMHTMLEmbedElement;

https://reviewboard.mozilla.org/r/166810/#review172500

r=me

::: xpcom/reflect/xptinfo/ShimInterfaceInfo.cpp
(Diff revision 1)
>    DEFINE_SHIM(HTMLCanvasElement),
>    DEFINE_SHIM(HTMLCollection),
>    DEFINE_SHIM(HTMLDirectoryElement),
>    DEFINE_SHIM(HTMLDocument),
>    DEFINE_SHIM(HTMLElement),
> -  DEFINE_SHIM(HTMLEmbedElement),

This is going to break the instanceof test in suite/browser/nsTypeAheadFind.js in comm-central.  Please file a bug on them to switch to some other method of detecting HTMLEmbedElement.

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Filed Bug 1389622 for comm-central followup.

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 5839ce212d53 -d 222deac54a16: rebasing 413061:5839ce212d53 "Bug 1387184 - Remove nsIDOMHTMLEmbedElement; r=bz" (tip)
other [source] changed addon-sdk/source/lib/sdk/content/context-menu.js which local [dest] deleted
use (c)hanged version, leave (d)eleted, or leave (u)nresolved? u
merging docshell/base/nsDocShellTreeOwner.cpp
merging dom/webbrowserpersist/WebBrowserPersistLocalDocument.cpp
merging editor/libeditor/HTMLEditorDataTransfer.cpp
merging layout/printing/nsPrintEngine.cpp
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8895597 [details]
Bug 1387184 - Remove nsIDOMHTMLEmbedElement;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166810/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4858624ff8c4
Remove nsIDOMHTMLEmbedElement; r=bz

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4858624ff8c4