Closed Bug 1387184 Opened 2 years ago Closed 2 years ago
Since it is no longer used (superceded by WebIDL), we can remove the members of nsIDOMHTMLEmbedElement, preparing it for complete removal when 57 moves to beta.
Since the pref to turn off extensions is supposed to land in nightly this week, I went ahead and removed the whole interface in this bug. Getting reviews now as it has passed try, but will wait to land until after pref is changed (need to find bug # for that).
Comment on attachment 8895597 [details] Bug 1387184 - Remove nsIDOMHTMLEmbedElement; https://reviewboard.mozilla.org/r/166810/#review172500 r=me ::: xpcom/reflect/xptinfo/ShimInterfaceInfo.cpp (Diff revision 1) > DEFINE_SHIM(HTMLCanvasElement), > DEFINE_SHIM(HTMLCollection), > DEFINE_SHIM(HTMLDirectoryElement), > DEFINE_SHIM(HTMLDocument), > DEFINE_SHIM(HTMLElement), > - DEFINE_SHIM(HTMLEmbedElement), This is going to break the instanceof test in suite/browser/nsTypeAheadFind.js in comm-central. Please file a bug on them to switch to some other method of detecting HTMLEmbedElement.
Attachment #8895597 - Flags: review?(bzbarsky) → review+
Filed Bug 1389622 for comm-central followup.
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 5839ce212d53 -d 222deac54a16: rebasing 413061:5839ce212d53 "Bug 1387184 - Remove nsIDOMHTMLEmbedElement; r=bz" (tip) other [source] changed addon-sdk/source/lib/sdk/content/context-menu.js which local [dest] deleted use (c)hanged version, leave (d)eleted, or leave (u)nresolved? u merging docshell/base/nsDocShellTreeOwner.cpp merging dom/webbrowserpersist/WebBrowserPersistLocalDocument.cpp merging editor/libeditor/HTMLEditorDataTransfer.cpp merging layout/printing/nsPrintEngine.cpp unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/4858624ff8c4 Remove nsIDOMHTMLEmbedElement; r=bz
Summary: Prepare nsIDOMHTMLEmbedElement for removal → Remove nsIDOMHTMLEmbedElement
You need to log in before you can comment on or make changes to this bug.