1389622 - Change nsIDOMHTMLEmbedElement access method in suite/browser/nsTypeAheadFind.js

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

In bug 1387184, we've removed the nsIDOMHTMLEmbedElement interface. This will be need to changed in comm-central suite/browser/nsTypeAheadFind.js.

Comment 1

[Frank-Rainer Grahl (:frg)]

> This will be need to changed in comm-central suite/browser/nsTypeAheadFind.js.

Any suggestions for a replacement?

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

I think 

document.commandDispatcher.focusedElement.tagname.toLowerCase() === "embed" 

might do it? ni?'ing bz 'cause I'm not sure that's the best way though.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Er, actually

document.commandDispatcher.focusedElement instanceof windows.content.HTMLEmbedElement

may also work and get rid of a nasty string compare. But I'll wait for bz's input.

Comment 4

[Boris Zbarsky [:bzbarsky]]

So using instanceof HTMLEmbedElement is a bit fragile because who knows when we'll break it working across globals.

I think 

  element.localName === "embed" && element.namespaceURI === "http://www.w3.org/1999/xhtml"

is the sanest option here.

Comment 5

[Frank-Rainer Grahl (:frg)]

Thanks guys. Really appreciate the help. A bit overwhelming right now with all the changes :)

Comment 7

[lvm]

re bug 1390467

In 2.54a1 builds prior to 20170813013143/windows and 20170813003001/linux when preferences-advanced-find as you type-show the find toolbar... (accessibility.typeaheadfind.usefindbar) was unchecked find as you type worked and the search target was shown on the status bar. In the latest builds unchecking this option breaks FAYT completely. If it is indeed caused by this change, it is not good at all: the find toolbar, at least the way it works now - popping up on top and shifting the page down, causes nothing but motion sickness, eye strain and annoyance - an very poor design choice, document should never move unless explicitly requested by user. Unless the find toolbar is redesigned to something more user-friendly the status bar FAYT should be maintained.

Comment 8

[Frank-Rainer Grahl (:frg)]

>  the status bar FAYT should be maintained.

Patience. No one wants to remove anything. A fix has been proposed and just needs to be implemented.

Comment 9

[Frank-Rainer Grahl (:frg)]

Attachment: 1389622-HTMLEmbedElement.patch

[Approval Request Comment]
Regression caused by (bug #): Bug 1387184
User impact if declined: broken find
Testing completed (on m-c, etc.): c-b
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Comment 10

[Ian Neal]

Comment on attachment 8966027 [details] [diff] [review]
1389622-HTMLEmbedElement.patch

LGTM r/a=me

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6e4f454d00c7
Remove usage of nsIDOMHTMLEmbedElement in SeaMonkey. r=IanN

Comment 12

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-beta/rev/99fcd281d389f920b85639810e82d149386d357b