1387242 - test_2_conformance__textures__misc__texture-upload-size.html fails with GL_OUT_OF_MEMORY

Status: RESOLVED DUPLICATE of bug 1388464

(Core :: Graphics: CanvasWebGL, defect, P3)

Description

[Kelsey Gilbert [:jgilbert]]

From bug 1386263:
> Push with failures:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=6f5695dcff2eaf89a798caa4ba14b5f330b32aa8&filter-
> resultStatus=testfailed&filter-resultStatus=busted&filter-
> resultStatus=exception&filter-resultStatus=retry&filter-
> resultStatus=usercancel&filter-resultStatus=runnable
[...]
> gl2 + gl3 with
> dom/canvas/test/webgl-conf/generated/
> test_2_conformance__textures__misc__texture-upload-size.html | getError
> expected: NO_ERROR. Was OUT_OF_MEMORY : when calling texImage2D
> 
> Please file new bug if these are two different issues.

Comment 1

[Kelsey Gilbert [:jgilbert]]

This isn't an actual OOM but rather an internal implementation error:
> 21:58:19     INFO -  GECKO(9428) | [GFX1-]: DXVA2D3D11 just crashed; hardware video will be disabled.
> 21:58:19     INFO -  GECKO(9428) | [9428] WARNING: DXVA2D3D11 crash detected: file z:/build/build/src/dom/media/platforms/wmf/DXVA2Manager.cpp, line 694
> 21:58:19     INFO -  GECKO(9428) | [9428] WARNING: NS_ENSURE_TRUE(SUCCEEDED(hr)) failed: file z:/build/build/src/dom/media/platforms/wmf/DXVA2Manager.cpp, line 1196
> 21:58:19     INFO -  GECKO(9428) | JavaScript warning: http://mochi.test:8888/tests/dom/canvas/test/webgl-conf/checkout/conformance/textures/misc/texture-npot-video.html, line 81: Error: WebGL warning: texImage2D: GetAsSourceSurface or GetDataSurface failed after blit failed for TexUnpackImage.
> 21:58:19     INFO -  GECKO(9428) | JavaScript warning: http://mochi.test:8888/tests/dom/canvas/test/webgl-conf/checkout/conformance/textures/misc/texture-npot-video.html, line 104: Error: WebGL warning: generateMipmap: The base level of the texture is not defined.
> 21:58:19     INFO -  Not taking screenshot here: see the one that was previously logged
> 21:58:19    ERROR -  1824 INFO TEST-UNEXPECTED-FAIL | dom/canvas/test/webgl-conf/generated/test_conformance__textures__misc__texture-npot-video.html | getError expected: INVALID_OPERATION. Was OUT_OF_MEMORY : should be INVALID_OPERATION

Specifically, this:
> texImage2D: GetAsSourceSurface or GetDataSurface failed after blit failed for TexUnpackImage.

Is:
https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/dom/canvas/TexUnpackBlob.cpp#735

It sounds like this may actually be related to the preferences issues. After failure 3 or so, we start getting this before the block shown above: (https://treeherder.mozilla.org/logviewer.html#?job_id=119752478&repo=try&lineNumber=17476)

> 21:58:19     INFO -  GECKO(9428) | [9428] WARNING: (debug) mSafeStream->Finish() failed within nsBufferedOutputStream::Flush()! Possible dataloss.: file z:/build/build/src/netwerk/base/nsBufferedStreams.cpp, line 875
> 21:58:19     INFO -  GECKO(9428) | [9428] WARNING: failed to save prefs file! possible data loss: file z:/build/build/src/modules/libpref/Preferences.cpp, line 328

It looks like it's not actually disabling the hardware decoder? Does that look right, :dvander?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

The patch for bug 1386263 takes care of this failure as well. Will let you dupe if/when you prefer, however :)