Remove custom styling for <toolbarbutton type="menu-button"> in the navigation and tab toolbars

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks 1 bug)

Trunk
Firefox 57
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
WebExtensions can't add such buttons we've removed our only one (the combined star and bookmarks menu button).
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8893588 [details]
Bug 1387253 - Remove custom styling for <toolbarbutton type=menu-button> in the navigation and tab toolbars.

https://reviewboard.mozilla.org/r/164668/#review170226

::: browser/themes/shared/toolbarbuttons.inc.css:85
(Diff revision 2)
> -.toolbarbutton-1 > .toolbarbutton-menubutton-button > .toolbarbutton-icon {
>    margin-inline-end: 0;
>  }
>  
> -:-moz-any(toolbar, .widget-overflow-list) .toolbarbutton-1 > .toolbarbutton-icon,
> -:-moz-any(toolbar, .widget-overflow-list) .toolbarbutton-1 > :-moz-any(.toolbarbutton-menubutton-button, .toolbarbutton-badge-stack) > .toolbarbutton-icon,
> +:-moz-any(toolbar, .widget-overflow-list) .toolbarbutton-1 > .toolbarbutton-badge-stack > .toolbarbutton-icon,
> +:-moz-any(toolbar, .widget-overflow-list) .toolbarbutton-1 > .toolbarbutton-icon {

Nit: If you reverse the order you can avoid touching hg blame.
Attachment #8893588 - Flags: review?(jhofmann) → review+
Comment hidden (mozreview-request)

Comment 5

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4269e394aa94
Remove custom styling for <toolbarbutton type=menu-button> in the navigation and tab toolbars. r=johannh
Assignee

Updated

2 years ago
Flags: qe-verify-
https://hg.mozilla.org/mozilla-central/rev/4269e394aa94
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Assignee

Updated

2 years ago
Blocks: 1406625
See Also: → 1253419
Assignee

Updated

2 years ago
Blocks: 1413499
Assignee

Updated

a year ago
Blocks: 1434860
You need to log in before you can comment on or make changes to this bug.