1387253 - Remove custom styling for <toolbarbutton type="menu-button"> in the navigation and tab toolbars

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Dão Gottwald [:dao]]

WebExtensions can't add such buttons we've removed our only one (the combined star and bookmarks menu button).

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1387253 - Remove custom styling for <toolbarbutton type=menu-button> in the navigation and tab toolbars.

Review commit: https://reviewboard.mozilla.org/r/164668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164668/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8893588 [details]
Bug 1387253 - Remove custom styling for <toolbarbutton type=menu-button> in the navigation and tab toolbars.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164668/diff/1-2/

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8893588 [details]
Bug 1387253 - Remove custom styling for <toolbarbutton type=menu-button> in the navigation and tab toolbars.

https://reviewboard.mozilla.org/r/164668/#review170226

::: browser/themes/shared/toolbarbuttons.inc.css:85
(Diff revision 2)
> -.toolbarbutton-1 > .toolbarbutton-menubutton-button > .toolbarbutton-icon {
>    margin-inline-end: 0;
>  }
>  
> -:-moz-any(toolbar, .widget-overflow-list) .toolbarbutton-1 > .toolbarbutton-icon,
> -:-moz-any(toolbar, .widget-overflow-list) .toolbarbutton-1 > :-moz-any(.toolbarbutton-menubutton-button, .toolbarbutton-badge-stack) > .toolbarbutton-icon,
> +:-moz-any(toolbar, .widget-overflow-list) .toolbarbutton-1 > .toolbarbutton-badge-stack > .toolbarbutton-icon,
> +:-moz-any(toolbar, .widget-overflow-list) .toolbarbutton-1 > .toolbarbutton-icon {

Nit: If you reverse the order you can avoid touching hg blame.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8893588 [details]
Bug 1387253 - Remove custom styling for <toolbarbutton type=menu-button> in the navigation and tab toolbars.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164668/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4269e394aa94
Remove custom styling for <toolbarbutton type=menu-button> in the navigation and tab toolbars. r=johannh

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4269e394aa94