The default bug view has changed. See this FAQ.

Support menu-button buttons in the browserAction API.

NEW
Assigned to

Status

()

Toolkit
WebExtensions: Frontend
P3
normal
a year ago
a day ago

People

(Reporter: kmag, Assigned: kmag)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [browserAction][triaged][design-decision-approved])

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Updated

a year ago
Whiteboard: [browserAction] → [browserAction][berlin]

Updated

11 months ago
Priority: -- → P3
Whiteboard: [browserAction][berlin] → [browserAction][berlin]triaged
(Assignee)

Updated

10 months ago
Whiteboard: [browserAction][berlin]triaged → [browserAction][triaged][design-decision-needed]

Updated

6 months ago
Component: WebExtensions: Untriaged → WebExtensions: Frontend

Comment 1

5 months ago
To be discussed during Nov. 15, 2016 web extensions triage meeting.

Comment 2

4 months ago
Kris, could describe this feature in a bit more detail please?
Flags: needinfo?(kmaglione+bmo)
Whiteboard: [browserAction][triaged][design-decision-needed] → [browserAction][triaged][design-decision-approved]
(Assignee)

Comment 3

4 months ago
Basically, we just need to create a menu-button type toolbar button, and then use something like contextMenus API to allow the extension to add menu items to it.
Flags: needinfo?(kmaglione+bmo)
This would be a secondary menu button (a little arrow pointing down) and the main action of the page action would still be something different?
(Assignee)

Comment 5

4 months ago
Yes.

Comment 6

4 months ago
Are you open for someone to make a proposal for this through a legacy addon exposing an API for a web extensions addon to use?

Comment 7

4 months ago
(In reply to brunoais from comment #6)
> Are you open for someone to make a proposal for this through a legacy addon
> exposing an API for a web extensions addon to use?

Could you expand on that please, I'm not sure I follow.

Comment 8

4 months ago
I write a legacy extension with the ideas of these docs:
https://webextensions-experiments.readthedocs.io/en/latest/how.html
and the same ideology as:
https://github.com/web-ext-experiments/logins

Then I do an example Web Extension that exemplifies of the new API in action just like logins example already does.
Flags: needinfo?(amckay)

Comment 9

4 months ago
Ah right, that sounds great.
Flags: needinfo?(amckay)

Comment 10

4 months ago
I won't be able to start on this in this month but I can start working on this in December. Anyone who wants to do it instead of me, feel free to do it and warning here to avoid both doing the same thing.

Comment 11

4 months ago
Created attachment 8814213 [details]
Example from adblock plus

Comment 12

4 months ago
Created attachment 8814238 [details]
Greasemonkey example

I prefer how they did with greasemonkey.
The vertical drawing in the middle making it clear there are two buttons seem better IMO.
Oh! By the way,
does anyone think we can allow any very small image or character instead of forcing the use of an inverted triangle?
(Assignee)

Updated

4 months ago
Assignee: nobody → kmaglione+bmo
(Assignee)

Updated

4 months ago
Duplicate of this bug: 1320876
(Assignee)

Updated

4 months ago
Assignee: kmaglione+bmo → tomica

Comment 14

4 months ago
> I prefer how they did with greasemonkey. The vertical drawing in the middle making it clear there are two buttons seem better IMO.

That’s the default appearance for <button type="menu-button">. And I also like it better. In Qt, a button with ABP’s appearance would behave like a BrowserAction with panel, i.e. it’s a (non-segmented) button that signifies that it triggers no immediate action but opens a panel.

> does anyone think we can allow any very small image or character instead of forcing the use of an inverted triangle?

sure! actually the segmented bookmark button is implemented like this. its right half is the arrow part of a menu-button, with overriden icon.

Comment 15

4 months ago
by the way: bug 1320876 isn’t actually a duplicate of this. there’s also real combined buttons, which that one is about.

those combined buttons could also be used to get a segmented button with multiple icons.

Updated

3 months ago
webextensions: --- → ?
Summary: Support menu-button buttons in the pageAction API. → Support menu-button buttons in the browserAction API.
Assignee: tomica → kmaglione+bmo

Updated

2 months ago
Blocks: 1311472

Comment 16

2 months ago
(In reply to Kris Maglione [:kmag] from comment #3)
> Basically, we just need to create a menu-button type toolbar button, and
> then use something like contextMenus API to allow the extension to add menu
> items to it.

Or not just menu buttons but panels too, I've an extensions that uses the drop marker to open a panel and the main button to do the main addon function.

Updated

a day ago
webextensions: ? → ---
You need to log in before you can comment on or make changes to this bug.