Closed Bug 1387303 Opened 3 years ago Closed 3 years ago

test_places_guid_downgrade.js isn't testing what it thinks it is

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: markh, Assigned: markh)

References

Details

Attachments

(1 file)

As discovered via bug 1375223, this test didn't get converted correctly in the new async world.

I'll put a patch up and will request review from Kit and Ed - only one review is needed though, so whoever gets to it first, please land it immediately to try and unblock bug 1375223 (if you wait for me to land it, it will likely be next week)
Assignee: nobody → markh
Comment on attachment 8893634 [details]
Bug 1387303 - fix test_places_guid_downgrade.js to work correctly in the new async-sync world.

https://reviewboard.mozilla.org/r/164726/#review170132

Oops, thank you Mark!
Attachment #8893634 - Flags: review?(eoger) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/edbd09a070b0
fix test_places_guid_downgrade.js to work correctly in the new async-sync world. r=eoger
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d77894bb0b45
fix test_places_guid_downgrade.js to work correctly in the new async-sync world. r=eoger
Flags: needinfo?(markh)
https://hg.mozilla.org/mozilla-central/rev/d77894bb0b45
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Attachment #8893634 - Flags: review?(kit)
See Also: → 1443268
You need to log in before you can comment on or make changes to this bug.