If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

test_places_guid_downgrade.js isn't testing what it thinks it is

RESOLVED FIXED in Firefox 57

Status

()

Firefox
Sync
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: markh, Assigned: markh)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
As discovered via bug 1375223, this test didn't get converted correctly in the new async world.

I'll put a patch up and will request review from Kit and Ed - only one review is needed though, so whoever gets to it first, please land it immediately to try and unblock bug 1375223 (if you wait for me to land it, it will likely be next week)
(Assignee)

Updated

2 months ago
Assignee: nobody → markh
Comment hidden (mozreview-request)

Comment 2

2 months ago
mozreview-review
Comment on attachment 8893634 [details]
Bug 1387303 - fix test_places_guid_downgrade.js to work correctly in the new async-sync world.

https://reviewboard.mozilla.org/r/164726/#review170132

Oops, thank you Mark!
Attachment #8893634 - Flags: review?(eoger) → review+

Comment 3

2 months ago
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/edbd09a070b0
fix test_places_guid_downgrade.js to work correctly in the new async-sync world. r=eoger

Comment 4

2 months ago
Backed out for eslint failures https://hg.mozilla.org/integration/autoland/rev/0c27d835497c539214e1ef464640c49342280f43
Flags: needinfo?(markh)

Comment 5

2 months ago
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d77894bb0b45
fix test_places_guid_downgrade.js to work correctly in the new async-sync world. r=eoger
(Assignee)

Updated

2 months ago
Flags: needinfo?(markh)
https://hg.mozilla.org/mozilla-central/rev/d77894bb0b45
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
(Assignee)

Updated

a month ago
Attachment #8893634 - Flags: review?(kit)
You need to log in before you can comment on or make changes to this bug.