1387303 - test_places_guid_downgrade.js isn't testing what it thinks it is

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

As discovered via bug 1375223, this test didn't get converted correctly in the new async world.

I'll put a patch up and will request review from Kit and Ed - only one review is needed though, so whoever gets to it first, please land it immediately to try and unblock bug 1375223 (if you wait for me to land it, it will likely be next week)

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1387303 - fix test_places_guid_downgrade.js to work correctly in the new async-sync world.

Review commit: https://reviewboard.mozilla.org/r/164726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164726/

Comment 2

[Edouard Oger [:eoger]]

Comment on attachment 8893634 [details]
Bug 1387303 - fix test_places_guid_downgrade.js to work correctly in the new async-sync world.

https://reviewboard.mozilla.org/r/164726/#review170132

Oops, thank you Mark!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edbd09a070b0
fix test_places_guid_downgrade.js to work correctly in the new async-sync world. r=eoger

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for eslint failures https://hg.mozilla.org/integration/autoland/rev/0c27d835497c539214e1ef464640c49342280f43

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d77894bb0b45
fix test_places_guid_downgrade.js to work correctly in the new async-sync world. r=eoger

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d77894bb0b45