Closed
Bug 1443268
Opened 6 years ago
Closed 6 years ago
Remove `test_places_guid_downgrade.js`
Categories
(Firefox :: Sync, enhancement, P2)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: lina, Assigned: tcsc)
References
Details
Attachments
(1 file)
`test_places_guid_downgrade.js` tests migrations between versions 10 and 11, which are ancient and no longer supported by Places: https://searchfox.org/mozilla-central/rev/d2b4b40901c15614fad2fa34718eea428774306e/toolkit/components/places/Database.cpp#1128-1135 What it *does* do, unfortunately, is fail unexpectedly if we initialize Places early, since accessing `PlacesUtils.{bookmarks, history}` for the first time will cause Places to run through the migration logic. o_O This means we can't call most `PlacesUtils` methods in `Engine#initialize`, for example. I think we can probably remove this test and its supporting files. Places has supported GUIDs everywhere for a while, and has debug assertions on database shutdown to ensure our tests don't violate that.
Comment 1•6 years ago
|
||
This causes unexpected grief, so let's do it sooner rather than later.
Priority: -- → P2
Updated•6 years ago
|
Assignee: nobody → tchiovoloni
Comment hidden (mozreview-request) |
Reporter | ||
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8956595 [details] Bug 1443268 - Remove test_places_guid_downgrade.js from sync https://reviewboard.mozilla.org/r/225514/#review231406 Good riddance! :-) Shall we get rid of `gSyncProfile`, too? It looks like no one else uses it besides this test.
Attachment #8956595 -
Flags: review?(kit) → review+
Comment hidden (mozreview-request) |
Pushed by tchiovoloni@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ba1e431204ab Remove test_places_guid_downgrade.js from sync r=kitcambridge
Comment 6•6 years ago
|
||
Backed out for failing xpcshell tests in services/sync/: https://hg.mozilla.org/integration/autoland/rev/128ccfeec9c2bcd37a0536ec6c030998b6101910 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ba1e431204ab065e0f99b90e4a8c01fd436d6a11&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Log: https://treeherder.mozilla.org/logviewer.html#?job_id=166536813&repo=autoland 09:53:57 INFO - TEST-START | services/sync/tests/unit/test_addon_utils.js 09:53:57 WARNING - TEST-UNEXPECTED-FAIL | services/sync/tests/unit/test_addon_utils.js | xpcshell return code: 0 09:53:57 INFO - TEST-INFO took 484ms 09:53:57 INFO - >>>>>>> 09:53:57 INFO - PID 5703 | JavaScript error: resource://gre/modules/osfile/ospath_unix.jsm, line 90: TypeError: invalid path component 09:53:57 INFO - Error: resource://gre/modules/FxAccounts.jsm - Could not get symbol 'fxAccounts'. at resource://services-sync/browserid_identity.js:12 09:53:57 INFO - @resource://services-sync/browserid_identity.js:12:1 09:53:57 INFO - @resource://services-sync/status.js:9:1 09:53:57 INFO - @resource://testing-common/services/sync/utils.js:24:1 09:53:57 INFO - @/Users/cltbld/tasks/task_1520443502/build/tests/xpcshell/tests/services/sync/tests/unit/head_helpers.js:21:1 09:53:57 INFO - load_file@/Users/cltbld/tasks/task_1520443502/build/tests/xpcshell/head.js:634:7 09:53:57 INFO - _load_files@/Users/cltbld/tasks/task_1520443502/build/tests/xpcshell/head.js:646:3 09:53:57 INFO - _execute_test@/Users/cltbld/tasks/task_1520443502/build/tests/xpcshell/head.js:511:3 09:53:57 INFO - @-e:1:1 And many more.
Flags: needinfo?(tchiovoloni)
Assignee | ||
Comment 7•6 years ago
|
||
TIL do_get_profile() has side effects.
Flags: needinfo?(tchiovoloni)
Comment hidden (mozreview-request) |
Pushed by tchiovoloni@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e6069d8a3daf Remove test_places_guid_downgrade.js from sync r=kitcambridge
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e6069d8a3daf
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•