Closed Bug 1443268 Opened 4 years ago Closed 4 years ago

Remove `test_places_guid_downgrade.js`


(Firefox :: Sync, enhancement, P2)




Firefox 60
Tracking Status
firefox60 --- fixed


(Reporter: lina, Assigned: tcsc)




(1 file)

`test_places_guid_downgrade.js` tests migrations between versions 10 and 11, which are ancient and no longer supported by Places:

What it *does* do, unfortunately, is fail unexpectedly if we initialize Places early, since accessing `PlacesUtils.{bookmarks, history}` for the first time will cause Places to run through the migration logic. o_O This means we can't call most `PlacesUtils` methods in `Engine#initialize`, for example.

I think we can probably remove this test and its supporting files. Places has supported GUIDs everywhere for a while, and has debug assertions on database shutdown to ensure our tests don't violate that.
This causes unexpected grief, so let's do it sooner rather than later.
Priority: -- → P2
Assignee: nobody → tchiovoloni
Comment on attachment 8956595 [details]
Bug 1443268 - Remove test_places_guid_downgrade.js from sync

Good riddance! :-) Shall we get rid of `gSyncProfile`, too? It looks like no one else uses it besides this test.
Attachment #8956595 - Flags: review?(kit) → review+
Pushed by
Remove test_places_guid_downgrade.js from sync r=kitcambridge
Backed out for failing xpcshell tests in services/sync/:

Push with failures:


09:53:57     INFO -  TEST-START | services/sync/tests/unit/test_addon_utils.js
09:53:57  WARNING -  TEST-UNEXPECTED-FAIL | services/sync/tests/unit/test_addon_utils.js | xpcshell return code: 0
09:53:57     INFO -  TEST-INFO took 484ms
09:53:57     INFO -  >>>>>>>
09:53:57     INFO -  PID 5703 | JavaScript error: resource://gre/modules/osfile/ospath_unix.jsm, line 90: TypeError: invalid path component
09:53:57     INFO -  Error: resource://gre/modules/FxAccounts.jsm - Could not get symbol 'fxAccounts'. at resource://services-sync/browserid_identity.js:12
09:53:57     INFO -  @resource://services-sync/browserid_identity.js:12:1
09:53:57     INFO -  @resource://services-sync/status.js:9:1
09:53:57     INFO -  @resource://testing-common/services/sync/utils.js:24:1
09:53:57     INFO -  @/Users/cltbld/tasks/task_1520443502/build/tests/xpcshell/tests/services/sync/tests/unit/head_helpers.js:21:1
09:53:57     INFO -  load_file@/Users/cltbld/tasks/task_1520443502/build/tests/xpcshell/head.js:634:7
09:53:57     INFO -  _load_files@/Users/cltbld/tasks/task_1520443502/build/tests/xpcshell/head.js:646:3
09:53:57     INFO -  _execute_test@/Users/cltbld/tasks/task_1520443502/build/tests/xpcshell/head.js:511:3
09:53:57     INFO -  @-e:1:1

And many more.
Flags: needinfo?(tchiovoloni)
TIL do_get_profile() has side effects.
Flags: needinfo?(tchiovoloni)
Pushed by
Remove test_places_guid_downgrade.js from sync r=kitcambridge
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.