1387413 - Pinned tabs should be 40px wide

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Dão Gottwald [:dao]]

as per https://mozilla.invisionapp.com/share/MRBK1MZF7#/screens/229786513

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1387413 - Make pinned tabs 40px wide.

Review commit: https://reviewboard.mozilla.org/r/164896/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164896/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8893786 [details]
Bug 1387413 - Make pinned tabs 40px wide.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164896/diff/1-2/

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8893786 [details]
Bug 1387413 - Make pinned tabs 40px wide.

https://reviewboard.mozilla.org/r/164896/#review170284

Looks good, thank you!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/faff9011f22c
Make pinned tabs 40px wide. r=johannh

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/faff9011f22c

Comment 6

[Azmina]

I have reproduced this bug with Nigtly 57.0a1 (2017-08-04) on Windows 8.1 (64 bit).

This bug's fix is verified on latest Nightly 57.0a1.

Build ID : 20170808114032
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0

Comment 7

[ovidiu boca[:Ovidiu]]

Attachment: 40px bug.png

I verified this issue on Mac Os X 10.10 and Windows 10 with the latest Nightly 57.0a1(2017-08-16) and the actual dimensions don't respect the spec dimension of 40 px. Please see the attachment.

Comment 8

[ovidiu boca[:Ovidiu]]

Any news about this issue?

Comment 9

[ovidiu boca[:Ovidiu]]

I verified this on Mac OS X 10.10 and Windows 10 and I can't reproduce this issue anymore. The only problem is on Mac when the pin is active the dimensions are 38px not 40px, I opened a new bug for this bug 1400162 and I'll mark the current bug as verified.