Pinned tabs should be 40px wide

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
3 months ago
a month ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 verified)

Details

(Whiteboard: [photon-visual])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

3 months ago
as per https://mozilla.invisionapp.com/share/MRBK1MZF7#/screens/229786513
Flags: qe-verify+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

3 months ago
mozreview-review
Comment on attachment 8893786 [details]
Bug 1387413 - Make pinned tabs 40px wide.

https://reviewboard.mozilla.org/r/164896/#review170284

Looks good, thank you!
Attachment #8893786 - Flags: review?(jhofmann) → review+

Comment 4

3 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/faff9011f22c
Make pinned tabs 40px wide. r=johannh

Updated

3 months ago
Iteration: --- → 57.1 - Aug 15
Priority: -- → P1
QA Contact: brindusa.tot
https://hg.mozilla.org/mozilla-central/rev/faff9011f22c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Blocks: 1387117

Comment 6

2 months ago
I have reproduced this bug with Nigtly 57.0a1 (2017-08-04) on Windows 8.1 (64 bit).

This bug's fix is verified on latest Nightly 57.0a1.

Build ID : 20170808114032
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170809]

Updated

2 months ago
QA Contact: brindusa.tot → ovidiu.boca

Comment 7

2 months ago
Created attachment 8898256 [details]
40px bug.png

I verified this issue on Mac Os X 10.10 and Windows 10 with the latest Nightly 57.0a1(2017-08-16) and the actual dimensions don't respect the spec dimension of 40 px. Please see the attachment.
Flags: needinfo?(dao+bmo)

Comment 8

a month ago
Any news about this issue?

Comment 9

a month ago
I verified this on Mac OS X 10.10 and Windows 10 and I can't reproduce this issue anymore. The only problem is on Mac when the pin is active the dimensions are 38px not 40px, I opened a new bug for this bug 1400162 and I'll mark the current bug as verified.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Flags: qe-verify+
Flags: needinfo?(dao+bmo)
You need to log in before you can comment on or make changes to this bug.