write a mochitest that terminates a Worker thread while it is consuming a ReadableStream

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P2
normal
RESOLVED FIXED
2 years ago
3 months ago

People

(Reporter: bkelly, Assigned: baku)

Tracking

(Blocks 2 bugs)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

This is a follow-on bug to address the review feedback from bug 1128959 comment 111.  We need a test that verifies the worker termination code with ReadableStream's WorkerHolder active.
Priority: -- → P2
Depends on: streams-enable
No longer depends on: streams-enable
No longer blocks: streams-enable
Assignee

Comment 1

7 months ago
Posted patch stream_worker.patch (obsolete) — Splinter Review
Assignee: nobody → amarchesini
Flags: needinfo?(jorendorff)
Assignee

Comment 2

7 months ago
Posted patch stream_worker.patch (obsolete) — Splinter Review
Attachment #9023242 - Attachment is obsolete: true
Depends on: 1505566
The first patch in bug 1505566 should fix the assertion we're hitting here.
No longer depends on: 1505566
Flags: needinfo?(jorendorff) → needinfo?(amarchesini)
Depends on: 1505566
Assignee

Comment 4

7 months ago
Posted patch stream_worker.patch (obsolete) — Splinter Review
I confirm, it works.
Attachment #9023255 - Attachment is obsolete: true
Flags: needinfo?(amarchesini)
Attachment #9023526 - Flags: review?(jorendorff)
Attachment #9023526 - Flags: review?(jorendorff) → review+
Assignee

Comment 5

7 months ago
A proper commit message.
Attachment #9023526 - Attachment is obsolete: true

Comment 6

7 months ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee2cb739dc5b
FestStreamReader should cancel the reader when the worker shutdowns, r=jorendorff

Comment 7

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ee2cb739dc5b
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.