Closed Bug 1387503 Opened 5 years ago Closed 4 years ago

write a mochitest that terminates a Worker thread while it is consuming a ReadableStream

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: bkelly, Assigned: baku)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 3 obsolete files)

This is a follow-on bug to address the review feedback from bug 1128959 comment 111.  We need a test that verifies the worker termination code with ReadableStream's WorkerHolder active.
Priority: -- → P2
Depends on: streams-enable
No longer depends on: streams-enable
No longer blocks: streams-enable
Attached patch stream_worker.patch (obsolete) — Splinter Review
Assignee: nobody → amarchesini
Flags: needinfo?(jorendorff)
Attached patch stream_worker.patch (obsolete) — Splinter Review
Attachment #9023242 - Attachment is obsolete: true
Depends on: 1505566
The first patch in bug 1505566 should fix the assertion we're hitting here.
No longer depends on: 1505566
Flags: needinfo?(jorendorff) → needinfo?(amarchesini)
Depends on: 1505566
Attached patch stream_worker.patch (obsolete) — Splinter Review
I confirm, it works.
Attachment #9023255 - Attachment is obsolete: true
Flags: needinfo?(amarchesini)
Attachment #9023526 - Flags: review?(jorendorff)
Attachment #9023526 - Flags: review?(jorendorff) → review+
A proper commit message.
Attachment #9023526 - Attachment is obsolete: true
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee2cb739dc5b
FestStreamReader should cancel the reader when the worker shutdowns, r=jorendorff
https://hg.mozilla.org/mozilla-central/rev/ee2cb739dc5b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.