write a mochitest that terminates a Worker thread while it is consuming a ReadableStream

RESOLVED FIXED in Firefox 65

Status

()

P2
normal
RESOLVED FIXED
2 years ago
3 months ago

People

(Reporter: bkelly, Assigned: baku)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

This is a follow-on bug to address the review feedback from bug 1128959 comment 111.  We need a test that verifies the worker termination code with ReadableStream's WorkerHolder active.
Priority: -- → P2
(Reporter)

Updated

2 years ago
Depends on: 1389628
(Reporter)

Updated

2 years ago
Blocks: 1389628
No longer depends on: 1389628
No longer blocks: 1389628
(Assignee)

Comment 1

3 months ago
Created attachment 9023242 [details] [diff] [review]
stream_worker.patch
Assignee: nobody → amarchesini
Flags: needinfo?(jorendorff)
(Assignee)

Comment 2

3 months ago
Created attachment 9023255 [details] [diff] [review]
stream_worker.patch
Attachment #9023242 - Attachment is obsolete: true
Depends on: 1505566
The first patch in bug 1505566 should fix the assertion we're hitting here.
No longer depends on: 1505566
Flags: needinfo?(jorendorff) → needinfo?(amarchesini)
Depends on: 1505566
(Assignee)

Comment 4

3 months ago
Created attachment 9023526 [details] [diff] [review]
stream_worker.patch

I confirm, it works.
Attachment #9023255 - Attachment is obsolete: true
Flags: needinfo?(amarchesini)
Attachment #9023526 - Flags: review?(jorendorff)
Attachment #9023526 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 5

3 months ago
Created attachment 9023996 [details] [diff] [review]
stream_worker.patch

A proper commit message.
Attachment #9023526 - Attachment is obsolete: true

Comment 6

3 months ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee2cb739dc5b
FestStreamReader should cancel the reader when the worker shutdowns, r=jorendorff

Comment 7

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ee2cb739dc5b
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.