This is a follow-on bug to address the review feedback from bug 1128959 comment 111. We need a test that verifies the worker termination code with ReadableStream's WorkerHolder active.
Created attachment 9023242 [details] [diff] [review] stream_worker.patch
Assignee: nobody → amarchesini
Created attachment 9023255 [details] [diff] [review] stream_worker.patch
Attachment #9023242 - Attachment is obsolete: true
The first patch in bug 1505566 should fix the assertion we're hitting here.
No longer depends on: 1505566
Flags: needinfo?(jorendorff) → needinfo?(amarchesini)
Created attachment 9023526 [details] [diff] [review] stream_worker.patch I confirm, it works.
Attachment #9023526 - Flags: review?(jorendorff) → review+
Created attachment 9023996 [details] [diff] [review] stream_worker.patch A proper commit message.
Attachment #9023526 - Attachment is obsolete: true
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ee2cb739dc5b FestStreamReader should cancel the reader when the worker shutdowns, r=jorendorff
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.