Closed Bug 1387511 Opened 3 years ago Closed 2 years ago

CSS Grid Inspector: Negative Line Numbers are Incorrect (on Implicit Grid)

Categories

(DevTools :: Inspector, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 59

People

(Reporter: jensimmons, Assigned: gl)

References

(Blocks 1 open bug)

Details

(Keywords: DevAdvocacy, Whiteboard: [DevRel:P1][designer-tools])

Attachments

(2 files)

Let's take a third swing at getting the line number placements correct under all conditions. (Getting so close!)

This is correct:
example: https://s.codepen.io/jensimmons/debug/brBMPZ
screenshot: https://monosnap.com/file/ki9EO0d6fXtShPMsaeANJGO60gPxvi.png
whole test: https://codepen.io/jensimmons/pen/brBMPZ

Yay!

Now we just need to do the same thing in the other direction — so the negative numbers start in the bottom left corner of the explicit grid, not just in the bottom right corner. 

Here's an example to show what's wrong:
example: https://s.codepen.io/jensimmons/debug/GENbzL
screenshot w/ correct numbers marked in hot pink: https://monosnap.com/file/Nza2PPBLnUYOppoqTcYSaykxXljgrl.png
whole test: https://codepen.io/jensimmons/pen/GENbzL?editors=1100

It's confusing, I know. This is why developers are going to LOVE our tool. We confused ourselves so they don't have to.
Summary: CSS Grid Inspector: Line Numbers Still (Sometimes) Incorrect, part 3 → CSS Grid Inspector: Negative Line Numbers are Incorrect (on Implicit Grid)
It's *really* important that we fix this. We cannot ship negative line numbers until this is fixed. 

You can also look at this test page from Igalia to see the problem.
https://igalia.github.io/css-grid-layout/grid-placement.html

Screenshot marking up reality vs what would be correct: 
https://monosnap.com/file/cWm41umRR62Gf6U5JXFDySIEARCTOb.png
Assignee: nobody → gl
Status: NEW → ASSIGNED
Depends on: 1415670
Priority: -- → P1
Whiteboard: [devRel:P1] → [DevRel:P1][designer-tools]
Comment on attachment 8928066 [details]
Bug 1387511 - Part 1: Use the grid negative number platform API to render negative line numbers correctly in css grid inspector.

https://reviewboard.mozilla.org/r/199298/#review204474
Attachment #8928066 - Flags: review?(pbrosset) → review+
Comment on attachment 8928067 [details]
Bug 1387511 - Part 2: Format css-grid.js

https://reviewboard.mozilla.org/r/199300/#review204476
Attachment #8928067 - Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0780ac4a74e
Part 1: Use the grid negative number platform API to render negative line numbers correctly in css grid inspector. r=pbro
https://hg.mozilla.org/integration/mozilla-inbound/rev/46a0be972d5a
Part 2: Format css-grid.js r=pbro
https://hg.mozilla.org/mozilla-central/rev/b0780ac4a74e
https://hg.mozilla.org/mozilla-central/rev/46a0be972d5a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.