1415670 - Add a negativeLineNumber to GridLine to be exposed to devtools

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Comment 1

[Brad Werth [:bradwerth] | Out until Feb 2025]

Attachment: Bug 1415670 Part 1: Add a negativeNumber property to GridLine in webidl.

Review commit: https://reviewboard.mozilla.org/r/197898/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197898/

Comment 2

[Brad Werth [:bradwerth] | Out until Feb 2025]

Attachment: Bug 1415670 Part 2: Calculate negativeNumber for each GridLine.

Review commit: https://reviewboard.mozilla.org/r/197900/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197900/

Comment 3

[Brad Werth [:bradwerth] | Out until Feb 2025]

Attachment: Bug 1415670 Part 3: Extend Grid tests to check negativeNumber property.

Review commit: https://reviewboard.mozilla.org/r/197902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197902/

Comment 4

[Brad Werth [:bradwerth] | Out until Feb 2025]

In implementing this, I've found a problem with the existing line numbers for grids where an implicit track is added before some removed repeat: auto-fit tracks. That needs to be fixed first to make this logic robust. I'll add a blocker bug soon.

Comment 5

[Brad Werth [:bradwerth] | Out until Feb 2025]

Comment on attachment 8926656 [details]
Bug 1415670 Part 1: Add a negativeNumber property to GridLine in webidl.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197898/diff/1-2/

Comment 6

[Brad Werth [:bradwerth] | Out until Feb 2025]

Comment on attachment 8926657 [details]
Bug 1415670 Part 2: Calculate negativeNumber for each GridLine.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197900/diff/1-2/

Comment 7

[Brad Werth [:bradwerth] | Out until Feb 2025]

Comment on attachment 8926658 [details]
Bug 1415670 Part 3: Extend Grid tests to check negativeNumber property.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197902/diff/1-2/

Comment 8

[Mats Palmgren (inactive)]

Comment on attachment 8926657 [details]
Bug 1415670 Part 2: Calculate negativeNumber for each GridLine.

https://reviewboard.mozilla.org/r/197900/#review204670

Comment 9

[Mats Palmgren (inactive)]

Comment on attachment 8926658 [details]
Bug 1415670 Part 3: Extend Grid tests to check negativeNumber property.

https://reviewboard.mozilla.org/r/197902/#review204674

Comment 10

[Mats Palmgren (inactive)]

Comment on attachment 8926658 [details]
Bug 1415670 Part 3: Extend Grid tests to check negativeNumber property.

https://reviewboard.mozilla.org/r/197902/#review204676

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8926656 [details]
Bug 1415670 Part 1: Add a negativeNumber property to GridLine in webidl.

https://reviewboard.mozilla.org/r/197898/#review204870

rs+ for

Comment 12

[Brad Werth [:bradwerth] | Out until Feb 2025]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b271c364b3009f292cc045525279afda422f8bc2

Comment 13

[Gabriel Luong [:gl] (ΦωΦ)]

Friendly reminder to land this soon.

Comment 14

[Brad Werth [:bradwerth] | Out until Feb 2025]

(In reply to Gabriel [:gl] (ΦωΦ) from comment #13)
> Friendly reminder to land this soon.

Blocking bugs have cleared. Trying to land it now.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92d2a5673bbc
Part 1: Add a negativeNumber property to GridLine in webidl. r=smaug
https://hg.mozilla.org/integration/autoland/rev/ec9fa6d9dca9
Part 2: Calculate negativeNumber for each GridLine. r=mats
https://hg.mozilla.org/integration/autoland/rev/812aaf31c577
Part 3: Extend Grid tests to check negativeNumber property. r=mats

Comment 16

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out 3 changesets (bug 1415670) for failing chrome test dom/grid/test/chrome/test_grid_implicit.html r=backout on a CLOSED TREE

https://treeherder.mozilla.org/logviewer.html#?job_id=149638383&repo=autoland&lineNumber=2633

https://hg.mozilla.org/integration/autoland/rev/715afcd248d8f731e07784eaf065d795b433d41f

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=812aaf31c57798aefc120d93057956eafcd67c2e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Comment 17

[Brad Werth [:bradwerth] | Out until Feb 2025]

(In reply to Bogdan Tara[:bogdan_tara] from comment #16)
> Backed out 3 changesets (bug 1415670) for failing chrome test
> dom/grid/test/chrome/test_grid_implicit.html r=backout on a CLOSED TREE
> 
> https://treeherder.mozilla.org/logviewer.
> html#?job_id=149638383&repo=autoland&lineNumber=2633

This is a super-weird result from the try server. The failures are issues that should have been resolved by blocker Bug 
1416350. Probably my patches just need a better rebasing. Trying that first.

Comment 18

[Brad Werth [:bradwerth] | Out until Feb 2025]

Comment on attachment 8926656 [details]
Bug 1415670 Part 1: Add a negativeNumber property to GridLine in webidl.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197898/diff/2-3/

Comment 19

[Brad Werth [:bradwerth] | Out until Feb 2025]

Comment on attachment 8926657 [details]
Bug 1415670 Part 2: Calculate negativeNumber for each GridLine.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197900/diff/2-3/

Comment 20

[Brad Werth [:bradwerth] | Out until Feb 2025]

Comment on attachment 8926658 [details]
Bug 1415670 Part 3: Extend Grid tests to check negativeNumber property.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197902/diff/2-3/

Comment 21

[Brad Werth [:bradwerth] | Out until Feb 2025]

(In reply to Brad Werth [:bradwerth] from comment #17)
> This is a super-weird result from the try server. The failures are issues
> that should have been resolved by blocker Bug 
> 1416350. Probably my patches just need a better rebasing. Trying that first.

No; there were logic problems in the patch which I have corrected. Attempting to land again. Sorry for the confusion!

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5961caa74ba
Part 1: Add a negativeNumber property to GridLine in webidl. r=smaug
https://hg.mozilla.org/integration/autoland/rev/dbb439bcdc03
Part 2: Calculate negativeNumber for each GridLine. r=mats
https://hg.mozilla.org/integration/autoland/rev/cfc0826e8cba
Part 3: Extend Grid tests to check negativeNumber property. r=mats

Comment 23

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f5961caa74ba
https://hg.mozilla.org/mozilla-central/rev/dbb439bcdc03
https://hg.mozilla.org/mozilla-central/rev/cfc0826e8cba