Closed Bug 1415670 Opened 3 years ago Closed 3 years ago

Add a negativeLineNumber to GridLine to be exposed to devtools

Categories

(Core :: CSS Parsing and Computation, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: gl, Assigned: bradwerth)

References

Details

(Whiteboard: [designer-tools])

Attachments

(3 files)

No description provided.
Blocks: 1387511
Priority: -- → P1
Whiteboard: [designer-tools]
In implementing this, I've found a problem with the existing line numbers for grids where an implicit track is added before some removed repeat: auto-fit tracks. That needs to be fixed first to make this logic robust. I'll add a blocker bug soon.
Depends on: 1416350
Attachment #8926656 - Flags: review?(bugs)
Attachment #8926657 - Flags: review?(mats)
Attachment #8926658 - Flags: review?(mats)
Comment on attachment 8926657 [details]
Bug 1415670 Part 2: Calculate negativeNumber for each GridLine.

https://reviewboard.mozilla.org/r/197900/#review204670
Attachment #8926657 - Flags: review?(mats) → review+
Comment on attachment 8926658 [details]
Bug 1415670 Part 3: Extend Grid tests to check negativeNumber property.

https://reviewboard.mozilla.org/r/197902/#review204674
Comment on attachment 8926658 [details]
Bug 1415670 Part 3: Extend Grid tests to check negativeNumber property.

https://reviewboard.mozilla.org/r/197902/#review204676
Attachment #8926658 - Flags: review?(mats) → review+
Comment on attachment 8926656 [details]
Bug 1415670 Part 1: Add a negativeNumber property to GridLine in webidl.

https://reviewboard.mozilla.org/r/197898/#review204870

rs+ for
Attachment #8926656 - Flags: review?(bugs) → review+
Friendly reminder to land this soon.
Flags: needinfo?(bwerth)
(In reply to Gabriel [:gl] (ΦωΦ) from comment #13)
> Friendly reminder to land this soon.

Blocking bugs have cleared. Trying to land it now.
Flags: needinfo?(bwerth)
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92d2a5673bbc
Part 1: Add a negativeNumber property to GridLine in webidl. r=smaug
https://hg.mozilla.org/integration/autoland/rev/ec9fa6d9dca9
Part 2: Calculate negativeNumber for each GridLine. r=mats
https://hg.mozilla.org/integration/autoland/rev/812aaf31c577
Part 3: Extend Grid tests to check negativeNumber property. r=mats
(In reply to Bogdan Tara[:bogdan_tara] from comment #16)
> Backed out 3 changesets (bug 1415670) for failing chrome test
> dom/grid/test/chrome/test_grid_implicit.html r=backout on a CLOSED TREE
> 
> https://treeherder.mozilla.org/logviewer.
> html#?job_id=149638383&repo=autoland&lineNumber=2633

This is a super-weird result from the try server. The failures are issues that should have been resolved by blocker Bug 
1416350. Probably my patches just need a better rebasing. Trying that first.
(In reply to Brad Werth [:bradwerth] from comment #17)
> This is a super-weird result from the try server. The failures are issues
> that should have been resolved by blocker Bug 
> 1416350. Probably my patches just need a better rebasing. Trying that first.

No; there were logic problems in the patch which I have corrected. Attempting to land again. Sorry for the confusion!
See Also: → 1423378
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5961caa74ba
Part 1: Add a negativeNumber property to GridLine in webidl. r=smaug
https://hg.mozilla.org/integration/autoland/rev/dbb439bcdc03
Part 2: Calculate negativeNumber for each GridLine. r=mats
https://hg.mozilla.org/integration/autoland/rev/cfc0826e8cba
Part 3: Extend Grid tests to check negativeNumber property. r=mats
https://hg.mozilla.org/mozilla-central/rev/f5961caa74ba
https://hg.mozilla.org/mozilla-central/rev/dbb439bcdc03
https://hg.mozilla.org/mozilla-central/rev/cfc0826e8cba
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.