Delay formautofill system add-on updates until the next restart

RESOLVED FIXED in Firefox 57

Status

()

Toolkit
Form Manager
--
major
RESOLVED FIXED
4 months ago
a month ago

People

(Reporter: MattN, Assigned: MattN)

Tracking

Trunk
mozilla57
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox56 unaffected, firefox57 fixed)

Details

(Whiteboard: [form autofill:M3], URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Since it's going to a be a lot of work and risk to tear down/replace all of the XPCOM components, JSMs, stylesheets, injected preferences, etc. at runtime and that doesn't seem worth it to support updates during runtime, we can instead delay any add-on updates until the next restart. This will still be much faster than only updating on Fx releases.

We just need to add an upgrade listener to the add-on and do nothing when it's called which means the upgrade won't be installed at that time.

http://searchfox.org/mozilla-central/rev/f0e4ae5f8c40ba742214e89aba3f554da0b89a33/toolkit/mozapps/extensions/test/xpcshell/data/test_delay_update_ignore/bootstrap.js#12,15-17,19-22
Flags: qe-verify+
Comment hidden (mozreview-request)
I didn't manually test this because it will take a lot of work and this is already covered by add-on manager unit tests (linked from comment 0). QE can verify when we start delivering as a system add-on.

Comment 3

4 months ago
mozreview-review
Comment on attachment 8894007 [details]
Bug 1387611 - Delay formautofill system add-on updates until the next restart.

https://reviewboard.mozilla.org/r/165086/#review170630

Thanks, Matt.
Attachment #8894007 - Flags: review?(lchang) → review+

Comment 4

4 months ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/347ea0d06092
Delay formautofill system add-on updates until the next restart. r=lchang

Comment 5

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/347ea0d06092
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Depends on: 1388078
Depends on: 1388285
Whiteboard: [form autofill:MVP] → [form autofill:M3]
(Assignee)

Comment 6

4 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/63ddd74e4578

Comment 7

a month ago
Matthew N, can you give us some guidelines on how can we test this fix? Thanks
Flags: needinfo?(MattN+bmo)
I don't think you can test this without an update to the system add-on being available via balrog. If you have an update staged this is trivial to test, just make sure the add-on doesn't update while Fx is running even when the update is downloaded.
Flags: needinfo?(MattN+bmo)
You need to log in before you can comment on or make changes to this bug.