1387650 - Associate json files with Firefox on OS X

Status: RESOLVED FIXED

(Firefox :: Shell Integration, enhancement)

Description

[Matthew N. [:MattN]]

Firefox is the best application to view JSON files on my Mac since bug 1243951 but it doesn't show in the Open With options by default since it doesn't advertise that it supports JSON files.

Firefox should advertise that it's a viewer of JSON files.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1387650 - Associate json files with the browser on OS X.

Review commit: https://reviewboard.mozilla.org/r/165148/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165148/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8894048 [details]
Bug 1387650 - Associate json files with the browser on OS X.

https://reviewboard.mozilla.org/r/165148/#review170496

::: browser/app/macbuild/Contents/Info.plist.in:42
(Diff revision 1)
> +			<key>CFBundleTypeOSTypes</key>
> +			<array>
> +				<string>TEXT</string>
> +			</array>

I wasn't sure about this part since I couldn't find good documentation online but it matches the SVG entry.

Comment 3

[Stephen A Pohl [:spohl]]

Comment on attachment 8894048 [details]
Bug 1387650 - Associate json files with the browser on OS X.

https://reviewboard.mozilla.org/r/165148/#review170906

::: browser/app/macbuild/Contents/Info.plist.in:42
(Diff revision 1)
> +			<array>
> +				<string>application/json</string>
> +			</array>
> +			<key>CFBundleTypeName</key>
> +			<string>JSON File</string>
> +			<key>CFBundleTypeOSTypes</key>

It seems like the CFBundleTypeOSTypes key is deprecated. However, it is used throughout this file and I would prefer changing it everywhere at once. Maybe we could open a bug to replace it throughout this file. Might make for a good-first-bug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8b9b3b2cd80
Associate json files with the browser on OS X. r=spohl

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a8b9b3b2cd80