1387784 - Update more icons to the photon style

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Tim Nguyen :ntim]

Subscribe, fullscreen (the standalone button, not the one in the menu), preferences, share, find in page need to be updated.

Comment 1

[Albert Scheiner [:alberts]]

what about the little sound icon on the tabs?

Comment 2

[Martin]

There is a separate bug about the fullscreen button (1387613).

Comment 4

[Tim Nguyen :ntim]

Attachment: Bug 1387784 - Update various icons to use photon style.

Review commit: https://reviewboard.mozilla.org/r/168032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168032/

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8896742 [details]
Bug 1387784 - Update various icons to use photon style.

https://reviewboard.mozilla.org/r/168032/#review173934

The urlbar history dropmarker is already taken care of in bug 1389740 :/

Comment 6

[Tim Nguyen :ntim]

Comment on attachment 8896742 [details]
Bug 1387784 - Update various icons to use photon style.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168032/diff/1-2/

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8896742 [details]
Bug 1387784 - Update various icons to use photon style.

https://reviewboard.mozilla.org/r/168032/#review176024

::: browser/themes/shared/identity-block/identity-block.inc.css:113
(Diff revision 2)
>  #urlbar[actiontype="searchengine"] > #identity-box > #identity-icon {
>    list-style-image: url(chrome://global/skin/icons/autocomplete-search.svg);
>  }
>  
>  #urlbar[actiontype="extension"] > #identity-box > #identity-icon {
> -  list-style-image: url(chrome://browser/skin/addons/addon-install-anchor.svg);
> +  list-style-image: url(chrome://browser/skin/addons.svg);

This file doesn't exist anymore, see bug 1389064

::: browser/themes/shared/menupanel.inc.css:5
(Diff revision 2)
>  /* Menu panel and palette styles */
>  
> -#appMenuRecentlyClosedWindows,
> +#appMenuRecentlyClosedWindows {
> +  list-style-image: url(chrome://browser/skin/window.svg);
> +}

Please move this rule to the bottom of this file

::: browser/themes/shared/urlbar-searchbar.inc.css:137
(Diff revision 2)
> +}
> +
> +#reader-mode-button[readeractive] {
> +  fill: var(--toolbarbutton-icon-fill-attention);
> +  fill-opacity: 1;
> +}

Please move this after the #pageActionButton rule at least

Comment 8

[Tim Nguyen :ntim]

Comment on attachment 8896742 [details]
Bug 1387784 - Update various icons to use photon style.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168032/diff/2-3/

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8896742 [details]
Bug 1387784 - Update various icons to use photon style.

https://reviewboard.mozilla.org/r/168032/#review176032

Great work, thanks!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff913409f74c
Update various icons to use photon style. r=dao

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ff913409f74c

Comment 13

[ovidiu boca[:Ovidiu]]

I want to verify this issue but I can't find the share icon, all the others are in customize. Tim, can you please tell me where I can find share icon? Thanks

Comment 14

[Tim Nguyen :ntim]

Hi Ovidiu,

The description is outdated, the share icon has been removed now.
Here's a list of icons that have been updated by this bug:
- Subscribe
- Fullscreen
- Find in page
- Settings
- Recently closed windows (hamburger menu > library > history)
- Zoom icons
- Reader mode icons
- Findbar arrows

Thanks.

Comment 15

[ovidiu boca[:Ovidiu]]

Thanks Tim,

I verified this on Mac OS X 10.12, Windows 10, Ubuntu 16.04 with FF Nightly 58.0a1(2017-10-08) and Beta 57.0b6 and I can confirm the fixed. 

Tim, when you say "Settings" do you mean "Options" - on Win and "Preferences" - on Mac and Ubuntu? Thanks.