1387800 - Remove [deprecated] nsIFilePicker.show()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1387800 - Remove [deprecated] nsIFilePicker.show().

Review commit: https://reviewboard.mozilla.org/r/165222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165222/

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 8894157 [details]
Bug 1387800 - Remove [deprecated] nsIFilePicker.show().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165222/diff/1-2/

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8894157 [details]
Bug 1387800 - Remove [deprecated] nsIFilePicker.show().

https://reviewboard.mozilla.org/r/165222/#review172908

::: widget/cocoa/nsFilePicker.h:50
(Diff revision 2)
>  
>  protected:
>    virtual ~nsFilePicker();
>  
>    virtual void InitNative(nsIWidget *aParent, const nsAString& aTitle) override;
> +  nsresult Show(int16_t *_retval) override; 

nit: extra space at end of line

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 8894157 [details]
Bug 1387800 - Remove [deprecated] nsIFilePicker.show().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165222/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dacffdd0ed1
Remove [deprecated] nsIFilePicker.show(). r=qdot

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6dacffdd0ed1