Closed Bug 1387803 Opened 2 years ago Closed 2 years ago

Remove the [deprecated] annotation from XPIDL

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(1 file)

* Currently [deprecated] has no effect on methods.
* [deprecated] has no effect on attributes due to a bug.
  deprecated = a.deprecated and "NS_DEPRECATED " or ""
  will always be evaluated as "".
* Even if we fixed the bug, NS_DEPRECATED is not defined anymore.
* We don't have to use [deprecated] in the first place in post-57 world.
  We can just remove the method, attribute, or interface.

So I'll remove the [deprecated] annotation rather than fixing it.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Apply this patch on top of blockers.
Comment on attachment 8894162 [details]
Bug 1387803 - Remove the [deprecated] annotation from XPIDL.

https://reviewboard.mozilla.org/r/165238/#review171222

::: xpcom/idl-parser/xpidl/header.py
(Diff revision 2)
> -    if iface.attributes.deprecated:
> -        fd.write("MOZ_DEPRECATED ")

I think `MOZ_DEPRECATED` is now unused; want to file a followup for removing that?
Attachment #8894162 - Flags: review?(nfroyd) → review+
Blocks: 1389702
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/1c9c19930d75
Remove the [deprecated] annotation from XPIDL. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/1c9c19930d75
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
I just updated https://developer.mozilla.org/en-US/docs/Mozilla/XPIDL to remove all mentions of |deprecated|.
You need to log in before you can comment on or make changes to this bug.