Remove the [deprecated] annotation from XPIDL

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: emk, Assigned: emk)

Tracking

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
* Currently [deprecated] has no effect on methods.
* [deprecated] has no effect on attributes due to a bug.
  deprecated = a.deprecated and "NS_DEPRECATED " or ""
  will always be evaluated as "".
* Even if we fixed the bug, NS_DEPRECATED is not defined anymore.
* We don't have to use [deprecated] in the first place in post-57 world.
  We can just remove the method, attribute, or interface.

So I'll remove the [deprecated] annotation rather than fixing it.
(Assignee)

Updated

a year ago
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
(Assignee)

Comment 2

a year ago
Apply this patch on top of blockers.
Comment hidden (mozreview-request)
Comment on attachment 8894162 [details]
Bug 1387803 - Remove the [deprecated] annotation from XPIDL.

https://reviewboard.mozilla.org/r/165238/#review171222

::: xpcom/idl-parser/xpidl/header.py
(Diff revision 2)
> -    if iface.attributes.deprecated:
> -        fd.write("MOZ_DEPRECATED ")

I think `MOZ_DEPRECATED` is now unused; want to file a followup for removing that?
Attachment #8894162 - Flags: review?(nfroyd) → review+
(Assignee)

Updated

a year ago
Blocks: 1389702

Comment 5

a year ago
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/1c9c19930d75
Remove the [deprecated] annotation from XPIDL. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/1c9c19930d75
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
I just updated https://developer.mozilla.org/en-US/docs/Mozilla/XPIDL to remove all mentions of |deprecated|.
You need to log in before you can comment on or make changes to this bug.