1387803 - Remove the [deprecated] annotation from XPIDL

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Masatoshi Kimura [:emk]]

* Currently [deprecated] has no effect on methods.
* [deprecated] has no effect on attributes due to a bug.
  deprecated = a.deprecated and "NS_DEPRECATED " or ""
  will always be evaluated as "".
* Even if we fixed the bug, NS_DEPRECATED is not defined anymore.
* We don't have to use [deprecated] in the first place in post-57 world.
  We can just remove the method, attribute, or interface.

So I'll remove the [deprecated] annotation rather than fixing it.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1387803 - Remove the [deprecated] annotation from XPIDL.

Review commit: https://reviewboard.mozilla.org/r/165238/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165238/

Comment 2

[Masatoshi Kimura [:emk]]

Apply this patch on top of blockers.

Comment 3

[Masatoshi Kimura [:emk]]

Comment on attachment 8894162 [details]
Bug 1387803 - Remove the [deprecated] annotation from XPIDL.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165238/diff/1-2/

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8894162 [details]
Bug 1387803 - Remove the [deprecated] annotation from XPIDL.

https://reviewboard.mozilla.org/r/165238/#review171222

::: xpcom/idl-parser/xpidl/header.py
(Diff revision 2)
> -    if iface.attributes.deprecated:
> -        fd.write("MOZ_DEPRECATED ")

I think `MOZ_DEPRECATED` is now unused; want to file a followup for removing that?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c9c19930d75
Remove the [deprecated] annotation from XPIDL. r=froydnj

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1c9c19930d75

Comment 7

[Nicholas Nethercote [inactive]]

I just updated https://developer.mozilla.org/en-US/docs/Mozilla/XPIDL to remove all mentions of |deprecated|.