1387805 - Remove [deprecated] nsIScriptSecurityManager.getCodebasePrincipal()

Status: RESOLVED FIXED

(Core :: Security: CAPS, enhancement)

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1387805 - Remove [deprecated] nsIScriptSecurityManager.getCodebasePrincipal().

Review commit: https://reviewboard.mozilla.org/r/165234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165234/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8894161 [details]
Bug 1387805 - Remove [deprecated] nsIScriptSecurityManager.getCodebasePrincipal().

https://reviewboard.mozilla.org/r/165234/#review170908

There are several uses of this function in comm-central.  Please make sure a bug is filed to fix those.

This function is used in a huge number of addons.  You should probably wait a few days until we turn off old-style addons altogether, to save a bunch of people the time it will take them to figure out why their browser is broken...

r+ with those caveats and the bit about symbol visibility below double-checked.

::: dom/security/test/gtest/TestCSPParser.cpp:101
(Diff revision 1)
>    nsCOMPtr<nsIURI> selfURI;
>    rv = NS_NewURI(getter_AddRefs(selfURI), "http://www.selfuri.com");
>    NS_ENSURE_SUCCESS(rv, rv);
>  
>    nsCOMPtr<nsIPrincipal> selfURIPrincipal;
> -  // Can't use BasePrincipal::CreateCodebasePrincipal here
> +  mozilla::OriginAttributes attrs;

Is this comment no longer true?

Comment 3

[Masatoshi Kimura [:emk]]

Comment on attachment 8894161 [details]
Bug 1387805 - Remove [deprecated] nsIScriptSecurityManager.getCodebasePrincipal().

https://reviewboard.mozilla.org/r/165234/#review170908

> Is this comment no longer true?

Yes, I can compile it without any problems. It failed until I added mozilla::, so the compiler actually compiles this file. Automation did not fail with this change either.

I don't know why the original author thought it was impossible to use BasePrincipal::CreateCodebasePrincipal here.

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 8894161 [details]
Bug 1387805 - Remove [deprecated] nsIScriptSecurityManager.getCodebasePrincipal().

https://reviewboard.mozilla.org/r/165234/#review170908

> There are several uses of this function in comm-central.  Please make sure a bug is filed to fix those.

Filed bug 1388347 and bug 1388350.

> This function is used in a huge number of addons.  You should probably wait a few days until we turn off old-style addons altogether, to save a bunch of people the time it will take them to figure out why their browser is broken...

Filed bug 1388355 to track this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42cf6375ccfd
Remove [deprecated] nsIScriptSecurityManager.getCodebasePrincipal(). r=bz

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/42cf6375ccfd