Closed Bug 1387890 Opened 7 years ago Closed 7 years ago

Going back from a tab opened by a webextension closes Firefox instead of the tab

Categories

(WebExtensions :: Android, enhancement)

All
Android
enhancement
Not set
normal

Tracking

(firefox55 wontfix, firefox56 fixed, firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox55 --- wontfix
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: JanH, Assigned: JanH)

Details

Attachments

(1 file)

Basically a repeat performance of bug 825016 - we don't pass the ID of the currently selected tab as parentId when opening a new tab.

Page actions already seem to do this correctly (https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/mobile/android/components/extensions/ext-pageAction.js#49), but ext-tabs.js doesn't (https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/mobile/android/components/extensions/ext-tabs.js#274) and needs to be fixed.
Comment on attachment 8894599 [details]
Bug 1387890 - Pass parentId for tabs opened by webextensions on Android.

https://reviewboard.mozilla.org/r/165738/#review170852

We should really probably use openerTabId for this, but I suppose this is a good compromise in the mean time.
Attachment #8894599 - Flags: review?(kmaglione+bmo) → review+
Also, when we implement openerTabId, maybe it might also make sense to keep this as a default value anyway in case an extension doesn't explicitly provide an openerTabId?
Assignee: nobody → jh+bugzilla
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/25f4fa1de401
Pass parentId for tabs opened by webextensions on Android. r=kmag
Comment on attachment 8894599 [details]
Bug 1387890 - Pass parentId for tabs opened by webextensions on Android.

Approval Request Comment
[Feature/Bug causing the regression]: Webextensions on Android
[User impact if declined]: Users can't close a tab opened by a webextension by simply pressing the back button to return to the previous tab.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: No (but verified locally).
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Other internal callers of BrowserApp.addTab() already use the currently selected tab as the parent tab for the new tab, this patch adds to same behaviour to the wrapper function used by webextensions
[String changes made/needed]: none
Attachment #8894599 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/25f4fa1de401
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment on attachment 8894599 [details]
Bug 1387890 - Pass parentId for tabs opened by webextensions on Android.

Fix for tab issue with webextensions, seems worth uplifting for 56.
Attachment #8894599 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Jan Henning [:JanH] from comment #5)
> [Is this code covered by automated tests?]: Yes.
> [Has the fix been verified in Nightly?]: No (but verified locally).
> [Needs manual test from QE? If yes, steps to reproduce]: No.

Setting qe-verify- based on Jan's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.