1387910 - stylo: getAnimations may return null for pseudo-element

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Test dom/base/test/test_domwindowutils.html fails with stylo inside test_getUnanimatedComputedStyle, specifically, it times out during executing
>       checkUnanimatedComputedStyle(property, initialStyle, "::before",
>                                    expectedInitialStyle, expectedInitialStyle,
>                                    pseudoAnimation, "Animation at pseudo");
because
>   const animation = animate(div);
in checkUnanimatedComputedStyle returns null, which leads to a JavaScript error.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Gosh, I didn't check this carefully. We need content property to generate the pseudo element properly.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1387910 - Set content property other than neither 'normal' nor 'none' to generate pseudo element properly.

Review commit: https://reviewboard.mozilla.org/r/165564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165564/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8894382 [details]
Bug 1387910 - Set content property other than neither 'normal' nor 'none' to generate pseudo element properly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165564/diff/1-2/

Comment 4

[Boris Chiou [:boris]]

Comment on attachment 8894382 [details]
Bug 1387910 - Set content property other than neither 'normal' nor 'none' to generate pseudo element properly.

https://reviewboard.mozilla.org/r/165564/#review170622

LGTM. Setting content property makes sense, just like what we did for Bug 1376247

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Hmmm... changing the test? It sounds like a content-observable behavior change, then. Should we file a bug to describe this difference against bug 1365771?

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Filed bug 1387931.  I was searching existing bugs but could not find it.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9b2f48e0afa3debdb63dfbe547a3171cfcf3eaf

Oops, now stylo is built by default, I could specify artifact builds there.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80648a32ef36
Set content property other than neither 'normal' nor 'none' to generate pseudo element properly. r=boris

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/80648a32ef36