1387917 - Turn on the pref "media.block-autoplay-until-in-foreground" by default

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Alastor Wu [:alwu]]

This feature is stable enough and we've got the QA's sign off report.
We can move it forward.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1387917 - Turn on the pref media.block-autoplay-until-in-foreground by default.

Review commit: https://reviewboard.mozilla.org/r/165568/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165568/

Comment 2

[Blake Wu [:bwu][:blakewu]]

Comment on attachment 8894385 [details]
Bug 1387917 - Turn on the pref media.block-autoplay-until-in-foreground by default.

https://reviewboard.mozilla.org/r/165568/#review170624

Ship it!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72c665591e29
Turn on the pref media.block-autoplay-until-in-foreground by default. r=bwu

Comment 4

[Alastor Wu [:alwu]]

Comment on attachment 8894385 [details]
Bug 1387917 - Turn on the pref media.block-autoplay-until-in-foreground by default.

Approval Request Comment
[Feature/Bug causing the regression]: New feature, see meta bug 1308154
[User impact if declined]: Can't block the autoplay media in new background tab
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: We've got the QA's sign off report
[String changes made/needed]: No

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/72c665591e29

Comment 6

[Caspy7]

Discussion and the approved relnote in bug 1308154 seem to indicate this was planned (and ready) for 56. Does it need some sort of uplift request?

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8894385 [details]
Bug 1387917 - Turn on the pref media.block-autoplay-until-in-foreground by default.

Great! Let's ship this turned on by default in 56 beta 1.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/524c06e940a4

Comment 9

[Ionuț Goldan [:igoldan]]

Improvement noticed:

== Change summary for alert #8616 (as of August 07 2017 01:21 UTC) ==

Improvements:

  2%  tp5o_webext summary linux64 opt e10s     294.46 -> 288.32

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=8616

Comment 10

[Danial Horton]

This "feature" causes facebook notification tones to leak memory in the parent process when facebook is not the active tab.