1387932 - stylo: column number of @supports rule is different from Gecko

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+11]

layout/inspector/tests/test_getRelativeRuleLine.html fails because of this.

The test expects the @supports to be at line 2 column 15, while Stylo returns line 2 column 14. But I think neither of them is correct, actually!

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

For this specific case, given both are not exactly correct, I guess we can just change the test to cover both cases...

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

What do you think is the correct value for the test?

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Gecko gets the column of the start of the opening parenthesis after the '@supports' keyword. While Stylo gets the column number right after the '@supports' keyword. This is the same behavior for all at-rule statements.

If we agree on a correct value, I can try to fix both implementations.

IMHO, the correct value should probably be 5, which is the start of the at-rule statement. This is what we do for other rules anyway.

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Bug 1387932 - stylo: add exception to inspector's test_getRelativeRuleLine.

Review commit: https://reviewboard.mozilla.org/r/167630/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167630/

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

In any case, the attached patch changes the test as suggested in comment 1.

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8896379 [details]
Bug 1387932 - stylo: add exception to inspector's test_getRelativeRuleLine.

https://reviewboard.mozilla.org/r/167630/#review173030

Comment 7

[Xidorn Quan [:xidorn] UTC+11]

I think the patch is fine. We can refine the result later.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f507b2b4981
stylo: add exception to inspector's test_getRelativeRuleLine. r=xidorn

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8f507b2b4981