Closed Bug 1387933 Opened 3 years ago Closed 2 years ago

stylo: Import stylesheets are not preserved after reparsing

Categories

(Core :: CSS Parsing and Computation, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: xidorn, Assigned: bradwerth)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Test layout/inspector/tests/test_parseStyleSheetImport.html checks this.

I'm not sure whether the inspector requires this invariant to behave correctly. We probably should preserve imported stylesheets after reparsing like what Gecko does.
This could potentially be tricky for Stylo, I guess...

Anything related to @import could become tricky :/
This is the LoaderReusableStyleSheets stuff?  I thought that was working.
Maybe we regressed it somehow. I think I didn't see this failure a while before.
Likely in code I've touched recently. I'll take a look.
Assignee: nobody → bwerth
This test doesn't fail for me, with or without e10s. It does show weird behavior in that the test summary page (with the passed/failed/todo counts) displays a purple background, so there could be some bug present. Does the test still fail for you?
Flags: needinfo?(xidorn+moz)
This test is enabled and marked fail-if [1] so it should still be failing on at least infra.

[1] https://searchfox.org/mozilla-central/rev/33295c6f4d57d16fe76476ac131cadd4cd3d05ad/layout/inspector/tests/mochitest.ini#37
Same as what I described in bug 1387913 comment 4, this test does still fail, and it shows green just because it is marked expected fail.
Flags: needinfo?(xidorn+moz)
Priority: -- → P2
Blocks: 1386862
Attachment #8899986 - Flags: review?(xidorn+moz)
Attachment #8899987 - Flags: review?(xidorn+moz)
Attachment #8899988 - Flags: review?(xidorn+moz)
Comment on attachment 8899986 [details]
Bug 1387933 Part 1: Servo-side add a reusable sheets parameter to Servo_StyleSheet_FromUTF8Bytes.

https://reviewboard.mozilla.org/r/171310/#review176518
Attachment #8899986 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8899987 [details]
Bug 1387933 Part 2: Gecko-side add a reusable sheets parameter to Servo_StyleSheet_FromUTF8Bytes, and mark a test as passing.

https://reviewboard.mozilla.org/r/171312/#review176520
Attachment #8899987 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8899988 [details]
Bug 1387933 Part 3: Mark as passing test_parseStyleSheetImport.html.

https://reviewboard.mozilla.org/r/171314/#review176522

This should probably be merged into part 2, actually.
Attachment #8899988 - Flags: review?(xidorn+moz) → review+
Attachment #8899988 - Attachment is obsolete: true
Attachment #8899986 - Attachment is obsolete: true
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e7e3c146e8c
Part 2: Gecko-side add a reusable sheets parameter to Servo_StyleSheet_FromUTF8Bytes, and mark a test as passing. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/1e7e3c146e8c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.