1387993 - Enable Stylo chrome mochitests on linux debug build

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Xidorn Quan [:xidorn] UTC+10]

In bug 1383992, they are currently marked as tier-3 and run on try only, because they fail consistently due to bug 1384701.

After that bug gets fixed, we should be able to enable those tests as tier-2 or tier-1.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(Changing bug summary and whiteboard to match :bholley's new scheme for infrastructure bugs like this.)

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

32-bit is also affected.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

browser-chrome appears unaffected, I filed bug 1393819 to enable it for linux64-stylo/debug (32-bit was already on and working).

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Yep, it looks like all tests are no longer affected.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=183bca8aff06dc698683c94cdea36489e21c40a5

Still need to figure out the failures and mark them correctly to enable them, though.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Oh, well, there is still one task affected. mochitest-chrome-1 on linux64.

My guess is that, the issue of bug 1384701 isn't really fixed, but with some recent changes (e.g. bug 1383332, bug 1393632), it becomes unlikely to hit in test documents (because they are small, and don't change a lot).

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Since clipboard and a11y appear to be working now, let's enable them to avoid regressions.

I filed bug 1394887 to do that.  We can leave this for mochitest chrome, which appears to still be blocked on the Cairo assertion.

In the Stylo meeting, we discussed how to proceed here to unblock flipping the default to Stylo.  For now, we will wait for :karlt's investigation.

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

We can actually enable mochitest-chrome as well. There is just a single test causing the shutdown assertion on linux64-stylo, which is caps/tests/mochitest/test_bug995943.xul.

See experiments in:
* https://treeherder.mozilla.org/#/jobs?repo=try&revision=66dbbfaabc5dc4738537bbabe65fe786e4fbb0cf&filter-tier=3
* https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a7538510d6348aed570231a37dff7b134d12185&filter-tier=3
* https://treeherder.mozilla.org/#/jobs?repo=try&revision=7732759ece5949ac7da5c4692bfce075a3555a86&filter-tier=3

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I think it's reasonable to disable layout/style/test/chrome/test_stylesheet_clone_import_rule.html for now if needed (bug 1378577) so we can move forward here and unblock flipping to Stylo.

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

I agree. I just need a bug to annotate on the skip-if, and I was not sure whether I should reopen the original bug for it, or open a new bug.

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #9)
> I agree. I just need a bug to annotate on the skip-if, and I was not sure
> whether I should reopen the original bug for it, or open a new bug.

Ah, a new bug 1395322 was filed, so that seems like the right one to mention.

Comment 11

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1387993 - Enable chrome mochitests on linux debug build.

Review commit: https://reviewboard.mozilla.org/r/174738/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174738/

Comment 12

[Xidorn Quan [:xidorn] UTC+10]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b085040e05e31e46306671b0f8e83435bd4f0927

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8902964 [details]
Bug 1387993 - Enable chrome mochitests on linux debug build.

https://reviewboard.mozilla.org/r/174738/#review179790

yay!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a039adf49a18
Enable chrome mochitests on linux debug build. r=jmaher

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a039adf49a18