1388001 - nsIEditingSession should have a method to return HTMLEditor instead of nsIEditor

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

nsIEditingSession should have a method to return HTMLEditor instead of nsIEditor. If there is, users of editing session can use concrete editor classes easier.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d24d4f39221935846de9f504adae81106d1ae2f4

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e92f2f76d7bfa0786f686f208b72ccf7d714988

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

Attachment: Bug 1388001 - part1: Create nsIEditingSession::GetHTMLEditorForWindow()

Some users of HTMLEditor retrieve pointer to editors with nsIEditingSession::GetEditorForWindow() but it returns nsIEditor.  So, there should be a method which returns HTMLEditor*.

Review commit: https://reviewboard.mozilla.org/r/167786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167786/

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

Attachment: Bug 1388001 - part2: nsEditingSession should treat editor as HTMLEditor

nsEditingSession should treat editor as HTMLEditor in its internal handling.

Review commit: https://reviewboard.mozilla.org/r/167788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167788/

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

Attachment: Bug 1388001 - part3: Remove nsIEditor argument of nsIHTMLDocument::TearingDownEditor() since it's unused

nsIHTMLDocument::TearingDownEditor() takes nsIEditor as an argument.  However, it's not used in it.  So, we can remove it.

Review commit: https://reviewboard.mozilla.org/r/167790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167790/

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

Attachment: Bug 1388001 - part4: nsHTMLDocument should treat editor as HTMLEditor

nsHTMLDocument retrieves its associated editor from nsIEditingSession and nsIDocShell.  So, both of them have methods returning HTMLEditor*. Therefore, nsHTMLDocument should treat all of them as HTMLEditor.

Review commit: https://reviewboard.mozilla.org/r/167800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167800/

Comment 7

[Makoto Kato [:m_kato]]

Comment on attachment 8896535 [details]
Bug 1388001 - part2: nsEditingSession should treat editor as HTMLEditor

https://reviewboard.mozilla.org/r/167788/#review173284

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8896536 [details]
Bug 1388001 - part3: Remove nsIEditor argument of nsIHTMLDocument::TearingDownEditor() since it's unused

https://reviewboard.mozilla.org/r/167790/#review173348

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8896534 [details]
Bug 1388001 - part1: Create nsIEditingSession::GetHTMLEditorForWindow()

https://reviewboard.mozilla.org/r/167786/#review173368

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8896537 [details]
Bug 1388001 - part4: nsHTMLDocument should treat editor as HTMLEditor

https://reviewboard.mozilla.org/r/167800/#review173370

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e0420e233f4
part1: Create nsIEditingSession::GetHTMLEditorForWindow() r=smaug
https://hg.mozilla.org/integration/autoland/rev/6280fc4d7468
part2: nsEditingSession should treat editor as HTMLEditor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b34a665b7879
part3: Remove nsIEditor argument of nsIHTMLDocument::TearingDownEditor() since it's unused r=smaug
https://hg.mozilla.org/integration/autoland/rev/5beaa5c88e20
part4: nsHTMLDocument should treat editor as HTMLEditor r=smaug

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8e0420e233f4
https://hg.mozilla.org/mozilla-central/rev/6280fc4d7468
https://hg.mozilla.org/mozilla-central/rev/b34a665b7879
https://hg.mozilla.org/mozilla-central/rev/5beaa5c88e20