Closed Bug 1388004 Opened 3 years ago Closed 3 years ago

nsContentUtils::GetHTMLEditor() should return HTMLEditor rather than nsIEditor

Categories

(Core :: DOM: Editor, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(3 files)

nsContentUtils::GetHTMLEditor() returns nsIEditor due to bug 1387406. However, after fixing it, it can return HTMLEditor.  Then, its callers can use concrete editor classes easier.
Comment on attachment 8896538 [details]
Bug 1388004 - part1: Make nsContentUtils::GetHTMLEditor() return HTMLEditor* rather than nsIEditor*

https://reviewboard.mozilla.org/r/167804/#review173392
Attachment #8896538 - Flags: review?(bugs) → review+
Comment on attachment 8896539 [details]
Bug 1388004 - part2: Make nsGenericHTMLElement::GetAssociatedEditor() return TextEditor instead of nsIEditor

https://reviewboard.mozilla.org/r/167806/#review173394
Attachment #8896539 - Flags: review?(bugs) → review+
Comment on attachment 8896540 [details]
Bug 1388004 - part3: nsINode::GetSelectionRootContent() should use HTMLEditor

https://reviewboard.mozilla.org/r/167808/#review173396
Attachment #8896540 - Flags: review?(bugs) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/6d7809a268d1
part1: Make nsContentUtils::GetHTMLEditor() return HTMLEditor* rather than nsIEditor* r=smaug
https://hg.mozilla.org/integration/autoland/rev/3d0b21e0de7a
part2: Make nsGenericHTMLElement::GetAssociatedEditor() return TextEditor instead of nsIEditor r=smaug
https://hg.mozilla.org/integration/autoland/rev/39a666756edd
part3: nsINode::GetSelectionRootContent() should use HTMLEditor r=smaug
You need to log in before you can comment on or make changes to this bug.