1388004 - nsContentUtils::GetHTMLEditor() should return HTMLEditor rather than nsIEditor

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

nsContentUtils::GetHTMLEditor() returns nsIEditor due to bug 1387406. However, after fixing it, it can return HTMLEditor.  Then, its callers can use concrete editor classes easier.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=313b52a8cc1c1645590b19f3a38bc0ad85c85a83

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0449c2a0dd176e712c25a832eaeba92eb9b544c6

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1388004 - part1: Make nsContentUtils::GetHTMLEditor() return HTMLEditor* rather than nsIEditor*

nsContentUtils::GetHTMLEditor() currently returns nsIEditor* since editor of doc shell may be any type of editors such as TextEditor or editor object which is implemented by JS.  However, nsIEditor is now a builtin class.  So, it can return HTMLEditor.

Review commit: https://reviewboard.mozilla.org/r/167804/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167804/

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1388004 - part2: Make nsGenericHTMLElement::GetAssociatedEditor() return TextEditor instead of nsIEditor

nsGenericHTMLElement::GetAssociatedEditor() retrieves TextEditor if the element is <input type="text"> or something, or <textarea>, or if it's editable, HTMLEditor associated to the document.  So, this method can return TextEditor (HTMLEditor is a subclass of TextEditor).

Review commit: https://reviewboard.mozilla.org/r/167806/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167806/

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1388004 - part3: nsINode::GetSelectionRootContent() should use HTMLEditor

nsINode::GetSelectionRootContent() uses nsIEditor since nsContentUtils::GetHTMLEditor() returned nsIEditor.  Therefore, it needed to use GetEditorRootContent() to retrieve the editor root element as nsIContent*.

Now, it can use HTMLEditor and HTMLEditor::GetRoot() returns the editor root element as nsIContent* directly.  So, it should use HTMLEditor instead.

Review commit: https://reviewboard.mozilla.org/r/167808/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167808/

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8896538 [details]
Bug 1388004 - part1: Make nsContentUtils::GetHTMLEditor() return HTMLEditor* rather than nsIEditor*

https://reviewboard.mozilla.org/r/167804/#review173392

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8896539 [details]
Bug 1388004 - part2: Make nsGenericHTMLElement::GetAssociatedEditor() return TextEditor instead of nsIEditor

https://reviewboard.mozilla.org/r/167806/#review173394

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8896540 [details]
Bug 1388004 - part3: nsINode::GetSelectionRootContent() should use HTMLEditor

https://reviewboard.mozilla.org/r/167808/#review173396

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d7809a268d1
part1: Make nsContentUtils::GetHTMLEditor() return HTMLEditor* rather than nsIEditor* r=smaug
https://hg.mozilla.org/integration/autoland/rev/3d0b21e0de7a
part2: Make nsGenericHTMLElement::GetAssociatedEditor() return TextEditor instead of nsIEditor r=smaug
https://hg.mozilla.org/integration/autoland/rev/39a666756edd
part3: nsINode::GetSelectionRootContent() should use HTMLEditor r=smaug

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6d7809a268d1
https://hg.mozilla.org/mozilla-central/rev/3d0b21e0de7a
https://hg.mozilla.org/mozilla-central/rev/39a666756edd