Closed Bug 1388138 Opened 3 years ago Closed 3 years ago

The highlighting color of the active tab should be taken from the lightweight theme colors

Categories

(Firefox :: Theme, defect, P1)

57 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.1 - Aug 15
Tracking Status
firefox57 --- verified

People

(Reporter: u443210, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-visual][p4])

Attachments

(2 files)

Attached image bug.png
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170807113452

Steps to reproduce:

- Open Firefox Nightly.
- Install some lightweight theme.



Actual results:

- Currently, the blue color of the active tab does not look good when a lightweight theme is applied.


Expected results:

- The highlight color should be calculated from the predominant colors of the lightweight theme, as is showed on this mockup:  http://design.firefox.com/people/shorlander/photon/Mockups/windows-10.html (Check: Theme -> Spring Rain).
Component: Untriaged → Theme
Whiteboard: [photon-visual][triage]
Blocks: photon-tabs
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: qe-verify+
Whiteboard: [photon-visual][triage] → [reserve-photon-visual][p4]
QA Contact: brindusa.tot
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: P3 → P1
Iteration: --- → 57.1 - Aug 15
Comment on attachment 8896597 [details]
Bug 1388138 - Use lightweight themes' accent color to highlight the selected tab.

https://reviewboard.mozilla.org/r/167878/#review173386

I have to say that browsing through the themes section on AMO, not a lot of themes are well-prepared for this setting. Many have either a transparent accent color or use the same as their tab strip background. The selected tab is still distinguishable when that's the case though, through the remaining highlighting. So r=me.
Attachment #8896597 - Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90526e8f3efe
Use lightweight themes' accent color to highlight the selected tab. r=johannh
https://hg.mozilla.org/mozilla-central/rev/90526e8f3efe
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I use https://addons.mozilla.org/en-US/firefox/addon/the-snowy-mountains-theme/
Now the highlighting color is white and it looks so ugly. The previous blue was much better.
I have reproduced this bug with Nightly 57.0a1 (2017-08-07) on Windows 8.1, 64 Bit!

This bug's fix is verified on Latest Nightly 57.0a1.

Build ID : 20170817100132
User Agent : Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170816]
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-15), so I'm marking this bug as VERIFIED. Thanks.
Status: RESOLVED → VERIFIED
QA Contact: brindusa.tot → Virtual
Flags: qe-verify+
Depends on: 1404108
Depends on: 1508081
You need to log in before you can comment on or make changes to this bug.