1388138 - The highlighting color of the active tab should be taken from the lightweight theme colors

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[u443210]

Attachment: bug.png

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170807113452

Steps to reproduce:

- Open Firefox Nightly.
- Install some lightweight theme.



Actual results:

- Currently, the blue color of the active tab does not look good when a lightweight theme is applied.


Expected results:

- The highlight color should be calculated from the predominant colors of the lightweight theme, as is showed on this mockup:  http://design.firefox.com/people/shorlander/photon/Mockups/windows-10.html (Check: Theme -> Spring Rain).

Comment 1

[Dão Gottwald [::dao]]

Attachment: Bug 1388138 - Use lightweight themes' accent color to highlight the selected tab.

Review commit: https://reviewboard.mozilla.org/r/167878/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167878/

Comment 2

[Johann Hofmann [:johannh] - On leave until October, slow/no response on BMO, DM me if urgent]

Comment on attachment 8896597 [details]
Bug 1388138 - Use lightweight themes' accent color to highlight the selected tab.

https://reviewboard.mozilla.org/r/167878/#review173386

I have to say that browsing through the themes section on AMO, not a lot of themes are well-prepared for this setting. Many have either a transparent accent color or use the same as their tab strip background. The selected tab is still distinguishable when that's the case though, through the remaining highlighting. So r=me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90526e8f3efe
Use lightweight themes' accent color to highlight the selected tab. r=johannh

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/90526e8f3efe

Comment 5

[Johann Hofmann [:johannh] - On leave until October, slow/no response on BMO, DM me if urgent]

Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=824d4f269c6323e1ad2bd8ebeb6496d60b8ba3e5&newProject=mozilla-central&newRev=92f3de33d97f55d54b2baad585b87e76aaa5ec58

The Linux screenshots with LWT are good examples of what I meant in comment 2. I think it's still obvious what the selected tab is, but it doesn't look as nice anymore.

Comment 6

[Oriol Brufau [:Oriol]]

I use https://addons.mozilla.org/en-US/firefox/addon/the-snowy-mountains-theme/
Now the highlighting color is white and it looks so ugly. The previous blue was much better.

Comment 7

[Azmina]

I have reproduced this bug with Nightly 57.0a1 (2017-08-07) on Windows 8.1, 64 Bit!

This bug's fix is verified on Latest Nightly 57.0a1.

Build ID : 20170817100132
User Agent : Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Comment 8

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-15), so I'm marking this bug as VERIFIED. Thanks.