Closed
Bug 1388138
Opened 8 years ago
Closed 8 years ago
The highlighting color of the active tab should be taken from the lightweight theme colors
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox57 | --- | verified |
People
(Reporter: u443210, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [reserve-photon-visual][p4])
Attachments
(2 files)
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170807113452
Steps to reproduce:
- Open Firefox Nightly.
- Install some lightweight theme.
Actual results:
- Currently, the blue color of the active tab does not look good when a lightweight theme is applied.
Expected results:
- The highlight color should be calculated from the predominant colors of the lightweight theme, as is showed on this mockup: http://design.firefox.com/people/shorlander/photon/Mockups/windows-10.html (Check: Theme -> Spring Rain).
Updated•8 years ago
|
Component: Untriaged → Theme
Updated•8 years ago
|
Whiteboard: [photon-visual][triage]
Updated•8 years ago
|
Blocks: photon-tabs
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: qe-verify+
Whiteboard: [photon-visual][triage] → [reserve-photon-visual][p4]
Updated•8 years ago
|
Priority: -- → P3
Updated•8 years ago
|
QA Contact: brindusa.tot
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: P3 → P1
Updated•8 years ago
|
Iteration: --- → 57.1 - Aug 15
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8896597 [details]
Bug 1388138 - Use lightweight themes' accent color to highlight the selected tab.
https://reviewboard.mozilla.org/r/167878/#review173386
I have to say that browsing through the themes section on AMO, not a lot of themes are well-prepared for this setting. Many have either a transparent accent color or use the same as their tab strip background. The selected tab is still distinguishable when that's the case though, through the remaining highlighting. So r=me.
Attachment #8896597 -
Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90526e8f3efe
Use lightweight themes' accent color to highlight the selected tab. r=johannh
Comment 4•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 5•8 years ago
|
||
Screenshots:
https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=824d4f269c6323e1ad2bd8ebeb6496d60b8ba3e5&newProject=mozilla-central&newRev=92f3de33d97f55d54b2baad585b87e76aaa5ec58
The Linux screenshots with LWT are good examples of what I meant in comment 2. I think it's still obvious what the selected tab is, but it doesn't look as nice anymore.
Comment 6•8 years ago
|
||
I use https://addons.mozilla.org/en-US/firefox/addon/the-snowy-mountains-theme/
Now the highlighting color is white and it looks so ugly. The previous blue was much better.
I have reproduced this bug with Nightly 57.0a1 (2017-08-07) on Windows 8.1, 64 Bit!
This bug's fix is verified on Latest Nightly 57.0a1.
Build ID : 20170817100132
User Agent : Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170816]
Comment 8•8 years ago
|
||
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-15), so I'm marking this bug as VERIFIED. Thanks.
Updated•8 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•