Closed Bug 1388147 Opened 2 years ago Closed 2 years ago

[DataLoss] Eliminate SchemaTable

Categories

(Firefox for iOS :: Data Storage, defect, P1)

Other
iOS
defect

Tracking

()

RESOLVED FIXED
Iteration:
1.28
Tracking Status
fxios 9.0 ---

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

(Whiteboard: [MobileCore][DataLoss])

Attachments

(1 file)

55 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review
The `tableList` table (otherwise known as `SchemaTable`) is a source of major pain while trying to improve our DB init code. It needs to go.
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
Iteration: --- → 1.26
Priority: -- → P1
Whiteboard: [MobileCore][DataLoss]
Iteration: 1.26 → 1.27
Duplicate of this bug: 1382732
Attached file GitHub Pull Request
Preliminary WIP
Attachment #8896474 - Flags: feedback?(rnewman)
Iteration: 1.27 → 1.28
Comment on attachment 8896474 [details] [review]
GitHub Pull Request

Alright man... I think this MegaPatch™ is ready for review. Apologies in advance for the size of this PR. I owe you beers at next work week :-)
Attachment #8896474 - Flags: feedback?(rnewman) → review?(rnewman)
Blocks: 1368719
Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/1330e4e966c3c9d160c554d79f1e2db881ee2d55

Needs uplifted to v9.x
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Whiteboard: [MobileCore][DataLoss] → [MobileCore][DataLoss][needsuplift]
Comment on attachment 8896474 [details] [review]
GitHub Pull Request

Carrying over R+ from GitHub.
Attachment #8896474 - Flags: review?(rnewman) → review+
Landed on v9.x:

https://github.com/mozilla-mobile/firefox-ios/commit/81375eeb7f19704ca4282ae888a9245bbb3c5aa2
Whiteboard: [MobileCore][DataLoss][needsuplift] → [MobileCore][DataLoss]
Blocks: 1394185
You need to log in before you can comment on or make changes to this bug.