1394185 - SQL error or missing database no such table: tabs

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect, P1)

Description

[Justin D'Arcangelo [:justindarc]]

In the latest Firefox for iOS v9.0 Beta (5571), we're seeing the following error report in Sentry:

SQL error. Error code: 1, Error Domain=org.mozilla Code=1 "SQL error or missing database no such table: tabs" UserInfo={NSLocalizedDescription=SQL error or missing database no such table: tabs} for SQL CharacterView(_core: Swift._StringCore(_baseAddress: Optional(0x00000001c44a8600), _countAndFlags: 39, _owner: Optional(Swift.ManagedBuffer<Swift._HeapBufferHeader<Swift._StringBufferIVars>, Swift.UInt16>)), _coreOffset: 0).

This may be related to Bug 1388147 since `tabs` was one of the tables that was previously managed by the schema table.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Marking as P1 9.0 blocker and assigning to myself.

Comment 2

[Richard Newman [:rnewman]]

I thought we were seeing this earlier, too. My hypothesis then was that DB recovery in one process was blowing away the open DB, which will induce errors like this in the other process.

Comment 3

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8902427 [details] [review]
GitHub Pull Request

Carrying over R+ from GitHub

Comment 5

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/a6c25806f2e7e328937dd444c3bed0f0b0a408ea

Landed on v9.x:

https://github.com/mozilla-mobile/firefox-ios/commit/3d346fdf14bd00dd6d1449d0f220970cbf5373cb