Closed Bug 1388166 Opened 2 years ago Closed 2 years ago

Bug 1266836 introduced toolkit/browser dependency (breaks http auth on XUL apps) - follow up

Categories

(Toolkit :: Password Manager, defect, P1)

51 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
thunderbird_esr52 --- fixed
firefox-esr52 --- wontfix
firefox55 --- wontfix
firefox56 --- wontfix
firefox57 --- fixed

People

(Reporter: jorgk, Assigned: jorgk)

References

Details

(Keywords: regression)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1350152 +++

We still need to fix nsLoginManagerPrompter.js" line: 1437 reads:
      let tabbrowser = chromeWin.gBrowser || chromeWin.getBrowser();

when chromeWin has no getBrowser() function.
I don't know whether this fixes the problem, I'd like to get the people from bug 1358313 to try it.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8894650 - Flags: review?(jhofmann)
Comment on attachment 8894650 [details] [diff] [review]
1388166-login-manager.patch (v1)

Review of attachment 8894650 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the code, hopefully someone can confirm that this fixes the problem
Attachment #8894650 - Flags: review?(jhofmann) → review+
Thanks, I'll compile a version with this patch and get it to the reporters of bug 1358313.
This worked, so let's get it landed. Thank you, Johann.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf01128ff941
Handle case where chromeWin.getBrowser() doesn't exist. r=johannh
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bf01128ff941
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Blocks: 1347857
You need to log in before you can comment on or make changes to this bug.