Closed Bug 1388325 Opened 3 years ago Closed 2 years ago

Stop getting telemetry for deprecated feature in addons (JS_DEPRECATED_LANGUAGE_EXTENSIONS_IN_ADDONS)

Categories

(Core :: JavaScript Engine, enhancement, P3, minor)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

(Whiteboard: [js:tech-debt])

Attachments

(1 file)

given that so many legacy APIs are getting removed in bug 1347507,
it might be nice to just stop getting telemetry for deprecated feature in addons and just focus on web content usage.

currently we're tracking the usage of ForEach, LegacyGenerator, ExpressionClosure, and BlockScopeFunRedecl.

for-each is disabled in bug 1083470.

legacy generator is available only in versioned JS, and non-legacy addons shouldn't use it (am I correct?)

the count for BlockScopeFunRedecl is almost 0.

there might be some chance that expression closure is used in non-legacy addons tho...
(In reply to Tooru Fujisawa [:arai] from comment #0)
> legacy generator is available only in versioned JS, and non-legacy addons
> shouldn't use it (am I correct?)

Correct. we are actively preventing WebExtensions from using versioned JS (bug 1213632).
Priority: -- → P3
Whiteboard: [js:tech-debt]
almost a backout of bug 1211164.
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Attachment #8930081 - Flags: review?(jdemooij)
Comment on attachment 8930081 [details] [diff] [review]
Stop getting telemetry for deprecated feature in addons (JS_DEPRECATED_LANGUAGE_EXTENSIONS_IN_ADDONS)

Review of attachment 8930081 [details] [diff] [review]:
-----------------------------------------------------------------

Do you think this could be useful in the future for things like toSource and Array/String generics in web extensions?

r=me either way though.
Attachment #8930081 - Flags: review?(jdemooij) → review+
Thank you for reviewing :)

(In reply to Jan de Mooij [:jandem] from comment #3)
> Do you think this could be useful in the future for things like toSource and
> Array/String generics in web extensions?

we're already run out of buckets in that probe (bug 1331909, bug 1339777)
so the probe itself is not reusable.

the the change in JSCompartment methods can be reused once we decide to collect telemetry for webextensions.
Ah, makes sense!
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/966a8cda3001
Stop getting telemetry for deprecated feature in addons (JS_DEPRECATED_LANGUAGE_EXTENSIONS_IN_ADDONS) r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/966a8cda3001a83edbc796accabd79094f155f61
Bug 1388325 - Stop getting telemetry for deprecated feature in addons (JS_DEPRECATED_LANGUAGE_EXTENSIONS_IN_ADDONS) r=jandem
https://hg.mozilla.org/mozilla-central/rev/966a8cda3001
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.